chore: gate typescript majors behind dashboard approval - #2973
Merged
Conversation
The important-packages rule fast-tracks `typescript` past the dependency dashboard so minors/patches land promptly, but it also let the 6 -> 7 major (#2972) open unattended: a jump to the native compiler that every CI job failed at install (Renovate could not even regenerate the lockfile, the toolchain's peer ranges don't admit 7.x). A TypeScript major is a toolchain migration to be scheduled deliberately, not a dep bump. The new rule sits after the fast-track rule, so it overrides it for majors only; minors and patches keep the fast track.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
1 task
Contributor
📦 Bundle Stats —
|
| Metric | Value | vs main (f2c67f3) |
|---|---|---|
| Internal (raw) | 800.0 KB | - |
| Internal (gzip) | 153.3 KB | - |
| Bundled (raw) | 1.41 MB | - |
| Bundled (gzip) | 317.6 KB | - |
| Import time | 103ms | +0ms, +0.2% |
@portabletext/editor/behaviors
| Metric | Value | vs main (f2c67f3) |
|---|---|---|
| Internal (raw) | 467 B | - |
| Internal (gzip) | 207 B | - |
| Bundled (raw) | 424 B | - |
| Bundled (gzip) | 171 B | - |
| Import time | 2ms | -0ms, -0.7% |
@portabletext/editor/plugins
| Metric | Value | vs main (f2c67f3) |
|---|---|---|
| Internal (raw) | 2.7 KB | - |
| Internal (gzip) | 894 B | - |
| Bundled (raw) | 2.5 KB | - |
| Bundled (gzip) | 827 B | - |
| Import time | 7ms | -0ms, -0.9% |
@portabletext/editor/selectors
| Metric | Value | vs main (f2c67f3) |
|---|---|---|
| Internal (raw) | 81.2 KB | - |
| Internal (gzip) | 14.9 KB | - |
| Bundled (raw) | 76.9 KB | - |
| Bundled (gzip) | 13.8 KB | - |
| Import time | 8ms | +0ms, +0.6% |
@portabletext/editor/traversal
| Metric | Value | vs main (f2c67f3) |
|---|---|---|
| Internal (raw) | 28.1 KB | - |
| Internal (gzip) | 5.6 KB | - |
| Bundled (raw) | 28.1 KB | - |
| Bundled (gzip) | 5.5 KB | - |
| Import time | 6ms | +0ms, +1.3% |
@portabletext/editor/utils
| Metric | Value | vs main (f2c67f3) |
|---|---|---|
| Internal (raw) | 29.7 KB | - |
| Internal (gzip) | 6.2 KB | - |
| Bundled (raw) | 27.4 KB | - |
| Bundled (gzip) | 5.9 KB | - |
| Import time | 6ms | -0ms, -0.4% |
🗺️ . · ./behaviors · ./plugins · ./selectors · ./traversal · ./utils · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — @portabletext/markdown
Compared against main (f2c67f39)
| Metric | Value | vs main (f2c67f3) |
|---|---|---|
| Internal (raw) | 53.8 KB | - |
| Internal (gzip) | 9.8 KB | - |
| Bundled (raw) | 348.9 KB | - |
| Bundled (gzip) | 96.3 KB | - |
| Import time | 42ms | +1ms, +3.5% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renovate opened #2972 (typescript 6.0.3 → 7.0.2) unattended and every CI job failed at install in under 25 seconds: the
renovate/artifactsfailure shows it couldn't even regenerate the lockfile, the toolchain's peer ranges (typescript-eslint, the build tooling) don't admit 7.x, so the catalog andpnpm-lock.yamldiverged and--frozen-lockfiledied in every job.The PR existed at all because the important-packages rule fast-tracks
typescriptpast the dependency dashboard, which is right for minors/patches (keep TS current) but wrong for majors: 6 → 7 is the jump to the native Go compiler, a deliberate toolchain migration touchingcheck:types, declaration emit, and every TS-peer'd build tool. The catalog even pins TS exactly (6.0.3), signaling it's deliberately managed.This adds one packageRule after the fast-track rule (later rules override earlier ones for what they match):
typescript+matchUpdateTypes: ["major"]→ back behind dashboard approval. Minors and patches keep the fast track. Same shape as the vitest changeset fix (#2964): a package rule that was missing a majors carve-out.#2972 is closed in favor of a deliberate TS7 migration whenever it's chosen.