Show progress bar without commands enabled

[brandyballoon]

No description provided.

[pop4959]

Hey, thanks for the PR! I'm assuming you're taking a look at #450 and #479 with this?

Just removing the permission check here entirely isn't correct though, it should be checking for the player's permissions instead of gamemaster (which defaults to gamemaster if a permission mod isn't installed), or if the server is running in Singleplayer mode. You can test this with LuckPerms.

[brandyballoon]

OK sorry it was a quick hack without fully understanding how it works. Yes I found #450 but didn't look at #479 yet. Thanks for the feedback.

[brandyballoon]

If I were to have a go at doing this properly, what is the desired behavior for the remote players when a single player world is opened to LAN with commands off?

[pop4959]

If I were to have a go at doing this properly, what is the desired behavior for the remote players when a single player world is opened to LAN with commands off?

As I described above, but as an example the /chunky command permissions currently work the same way the boss bar is intended to, so you can have a look at that for an example. It's a relatively minor change either way. If you're not able to figure it out, no worries because I was planning on making this change soon anyways when I have a chance to go through the issue backlog.

[brandyballoon]

How does it look now? Progress bar should now always show in single player mode (Fabric, Forge, NeoForge), and in multiplayer only if the player can run chunky commands or has chunky.progressbar (Fabric + LuckPerms) permission.