Repository navigation
fix: retry a rejected push even when git prints no hints - #204
Merged
Merged
Conversation
`git push --porcelain` reports a rejected ref on stdout; stderr only carries the "Updates were rejected" hints, and those can be switched off with advice.* — as on the CI runner. The classifier read stderr alone, so there a rejected push was "other" instead of "rejected": no pull, no retry, and the commits waited for the next scheduled pull. Classify on both streams. Also report UTC as a timezone offset of 0 rather than -0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI on
mainfailed after #203: 9 of the new git specs passed locally but failed on the runner.--porcelain,git pushwrites[rejected]to stdout; stderr only carries the "Updates were rejected" hints, andadvice.*config switches those off, as it evidently is on the runner. A rejected push was classified as "other", so it never pulled and retried, and the commits waited for the next scheduled pull. This is a real bug for any user with those hints off, not just a CI quirk.GitErrornow keeps stdout, and the classifier reads both streams.+0000came out as-0, which failstoBe(0)on a UTC runner.Evidence
mainhadTests 9 failed | 341 passed. Locally, the same 8 sync failures reproduce withadvice.pushUpdateRejected,advice.pushFetchFirstandadvice.pushNonFFCurrentset tofalse.retries a rejected push when git prints no hints(sets thoseadvice.*options throughextraConfig)reports UTC as a timezone offset of 0, not -0TZ=UTC(352 passed), and also normally (352 passed).Merge Danger
Door: two-way
Blast Radius: auto-sync
Only the error classification and one arithmetic line change.
🤖 Generated with Claude Code