Repository navigation
fix: insert only plain text when dropping onto a note - #193
Merged
Merged
Conversation
Dragging a pinned note into the editor inserted its wikilink followed by stray characters: the drop handler inserted every string item of the drag, including flavors other than text/plain. Only the text/plain item is inserted now; dropped files are handled as before. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Dragging a pinned note from the header into the editor inserted the note's wikilink followed by stray characters.
The note's drop handler inserted every string item of the drag. A drag can carry several string items besides
text/plain, such astext/uri-listandtext/html, and the browser can add private items of its own. The pinned note sets onlytext/plain(the wikilink), so the extra text came from those other items.Fix
handleDropinsrc/components/Note.tsxnow inserts only thetext/plainitem. File items still go through the unchangedkind === "file"branch, so a dropped image is still added to the graph with its.subtextsidecar, and its slug is inserted.Side effect: text dropped in from another app is now inserted once, as plain text. Before, the app's link or HTML version of the same text was inserted next to it.
Testing
tscpass.🤖 Generated with Claude Code