Skip to content

Fix memory leak in IOS7#382

Open
heroims wants to merge 9 commits into
pokeb:masterfrom
heroims:master
Open

Fix memory leak in IOS7#382
heroims wants to merge 9 commits into
pokeb:masterfrom
heroims:master

Conversation

@heroims

@heroims heroims commented Nov 29, 2013

Copy link
Copy Markdown

No description provided.

@jogu jogu mentioned this pull request Dec 2, 2013
@jogu

jogu commented Dec 2, 2013

Copy link
Copy Markdown
Collaborator

This looks like a relatively big change - is it possible to get a bit more info about why the old code was wrong, and how the new code solves it?

If anyone else tests the code in here, it would be great to have some comments to say if it works or not etc. (I don't have any live projects that still use ASIHTTPRequest.)

@LuoDengfeng

Copy link
Copy Markdown

I have tested this modification,it works out,solved the iOS 7 memory leak issue.Thanks for heroims' contribution!

@jogu

jogu commented Dec 13, 2013

Copy link
Copy Markdown
Collaborator

Great, thanks @LuoDengfeng

Has anyone been able to check if the metrics still work? (I think that's the bandwidth recording code etc.)

I'd be interested to know if anyone has checked it on Mac OS X or not too.

@danoli3

danoli3 commented Mar 26, 2014

Copy link
Copy Markdown

This is quite critical. Merge to Master @pokeb when you check it out :D!

@kejinlu

kejinlu commented Apr 14, 2014

Copy link
Copy Markdown

@pokeb can you fix the leak problem?

@jogu

jogu commented Apr 14, 2014

Copy link
Copy Markdown
Collaborator

pokeb isn't active on the project anymore.

I'm happy to look at merging this, but my time is very limited, so it's really useful if other people can help - the work that stills needs to be done is to resolve the conflicts, confirm if metrics still work and check this on Mac OS X.

@kejinlu

kejinlu commented Apr 17, 2014

Copy link
Copy Markdown

@heroims 我感觉这个修复,没有看出leak的真正的原因或者切入点在哪里。 只是覆盖了CFNetwork底层可能调用到的NSInputStream的一些没有公开的接口,万一以后苹果再更新它的实现,是不是又会出问题!

@heroims

heroims commented Apr 17, 2014

Copy link
Copy Markdown
Author

@kejinlu 那时候我再做新调整

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants