Repository navigation
fix: diagnose async initialization and verify Windows device lifecycles - #86
Merged
DennisSmolek merged 2 commits intoOct 7, 2026
Merged
Conversation
DennisSmolek
marked this pull request as ready for review
October 7, 2026 03:56
DennisSmolek
force-pushed
the
audit/windows-cross-device
branch
from
October 7, 2026 03:56
8f55bb4 to
90dbdf3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raw consumers can dispatch before asynchronous initialization completes, and Windows hybrid-GPU captures could name an adapter other than the rendering device. Add a once-per-instance migration warning and exported UpscalerNotReadyError (UPSCALER_NOT_READY), keep awaited rejections intact, and prevent bare ignored init rejections from adding unhandled errors. MomentsPass now rejects initialization after device loss.
Record actual adapter fields and validate expected vendors. Fix demo 13's resize resource growth by retaining its scene-pass identity and disposing owned targets; update DPR after monitor-scale changes. Preserve persisted pages and close owned browsers through the browser CDP session so Edge relaunches do not leave hung audit processes. Refuse occupied benchmark CDP ports.
Stacked on #85 → #84 → #83. The breaking init contract remains explicit on #83. This PR contains the requested diagnostics, before/after migration guide, Windows cross-device report, and compact evidence. No merge or publication.
Validation:
Remaining evidence limits: three r186.1 retains six binding buffers per fresh render-target instance with shared scene materials; this is recorded for upstream lifecycle work. No timing ranking is claimed below the measured noise floors. Physical sleep/resume, AMD/mobile tilers and forced FXC remain untested.
Refs #4, #35, #82. Details: docs/windows-cross-device.md and docs/async-init-migration.md.