Skip to content

repository prebake for agent runtimes - #809

Open
zreigz wants to merge 1 commit into
mainfrom
lukasz/prod-5150-repository-prebake-for-agent-runtimes
Open

repository prebake for agent runtimes#809
zreigz wants to merge 1 commit into
mainfrom
lukasz/prod-5150-repository-prebake-for-agent-runtimes

Conversation

@zreigz

@zreigz zreigz commented Aug 28, 2026

Copy link
Copy Markdown
Member

Test Plan

Checklist

  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added tests to cover my changes.
  • If required, I have updated the Plural documentation accordingly.

@zreigz
zreigz requested a review from a team as a code owner August 28, 2026 09:06
@linear

linear Bot commented Aug 28, 2026

Copy link
Copy Markdown

PROD-5150

@greptile-apps

greptile-apps Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR synchronizes the AgentRuntime CRD with repository prebaking and expanded runtime configuration.

  • Adds repositoryImage for prebaked repository OCI images.
  • Adds configurable remote MCP servers, headers, and tool allowlists.
  • Refreshes generated runtime and embedded Kubernetes PodSpec schema fields.

Confidence Score: 4/5

The PR appears safe to merge, with a non-blocking opportunity to reject malformed MCP endpoint URLs during admission.

The new MCP server URL schema accepts any nonempty string even though downstream configuration requires a usable HTTP endpoint, deferring a readily detectable configuration error.

Files Needing Attention: charts/deployment-operator/crds/deployments.plural.sh_agentruntimes.yaml

Important Files Changed

Filename Overview
charts/deployment-operator/crds/deployments.plural.sh_agentruntimes.yaml Adds repository prebaking and remote MCP configuration to the public AgentRuntime schema; the MCP endpoint currently admits malformed non-HTTP values.

Reviews (1): Last reviewed commit: "repository prebake for agent runtimes" | Re-trigger Greptile

Comment on lines +2253 to +2256
url:
description: URL is the remote streamable HTTP MCP endpoint.
minLength: 1
type: string

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 MCP endpoint lacks URL validation

The schema accepts any nonempty mcpServers[].url, including malformed or non-HTTP values, even though the field requires a remote streamable HTTP endpoint. This defers a detectable configuration error until reconciliation or agent execution and leaves the configured MCP server unavailable.

Knowledge Base Used:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants