repository prebake for agent runtimes - #809
Conversation
Greptile SummaryThe PR synchronizes the AgentRuntime CRD with repository prebaking and expanded runtime configuration.
Confidence Score: 4/5The PR appears safe to merge, with a non-blocking opportunity to reject malformed MCP endpoint URLs during admission. The new MCP server URL schema accepts any nonempty string even though downstream configuration requires a usable HTTP endpoint, deferring a readily detectable configuration error. Files Needing Attention: charts/deployment-operator/crds/deployments.plural.sh_agentruntimes.yaml
|
| Filename | Overview |
|---|---|
| charts/deployment-operator/crds/deployments.plural.sh_agentruntimes.yaml | Adds repository prebaking and remote MCP configuration to the public AgentRuntime schema; the MCP endpoint currently admits malformed non-HTTP values. |
Reviews (1): Last reviewed commit: "repository prebake for agent runtimes" | Re-trigger Greptile
| url: | ||
| description: URL is the remote streamable HTTP MCP endpoint. | ||
| minLength: 1 | ||
| type: string |
There was a problem hiding this comment.
MCP endpoint lacks URL validation
The schema accepts any nonempty mcpServers[].url, including malformed or non-HTTP values, even though the field requires a remote streamable HTTP endpoint. This defers a detectable configuration error until reconciliation or agent execution and leaves the configured MCP server unavailable.
Knowledge Base Used:
Test Plan
Checklist