Skip to content

fix(tag): allow multiple item types in massive updates#362

Open
rickserrat wants to merge 1 commit into
pluginsGLPI:mainfrom
rickserrat:fix/massive-update-multiple-item-types
Open

fix(tag): allow multiple item types in massive updates#362
rickserrat wants to merge 1 commit into
pluginsGLPI:mainfrom
rickserrat:fix/massive-update-multiple-item-types

Conversation

@rickserrat

Copy link
Copy Markdown

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective.
  • I have updated the CHANGELOG with a short functional description of the fix.
  • This change requires a documentation update.

Description

  • Fixes Massive update of associated item types only allows a single value #361 .
  • Allows users to select multiple associated item types when updating tags through massive actions.
  • Preserves the existing behavior of replacing the current associated item type list.
  • Submits the selected item types as an array.
  • Adds a regression test covering multiple selected item types.

This issue is separate from #359 and PR #360. Those changes handle scalar values submitted by the existing single-select field, while this pull request changes the massive action field to support multiple selections.

Testing

  • Verified that multiple associated item types can be selected.
  • Verified that all selected values are stored in type_menu.
  • Verified that the selected values are applied to all tags included in the massive action.
  • Ran the PHPUnit test suite successfully.

Screenshots

before after

Before

The massive action field only accepts one associated item type.

After

The massive action field accepts multiple associated item types.

@rickserrat
rickserrat marked this pull request as ready for review July 20, 2026 19:57
@Rom1-B
Rom1-B self-requested a review July 24, 2026 10:36

@Rom1-B Rom1-B left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase to resolve the conflicts
and then fix the lint issues?

Comment thread inc/tag.class.php Outdated
@rickserrat
rickserrat force-pushed the fix/massive-update-multiple-item-types branch from 8ff1d3e to 81d9ccc Compare July 24, 2026 12:36
@rickserrat

Copy link
Copy Markdown
Author

Can you rebase to resolve the conflicts and then fix the lint issues?

Thanks for the review.

I rebased the branch onto the latest main, resolved the conflicts, removed the unrelated defensive check, and fixed the lint and licence header issues.

The updated branch has been pushed and the workflow is now awaiting approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Massive update of associated item types only allows a single value

2 participants