pkp/pkp-lib#12509 Add Crossref support for peer review DOIs#93
Open
taslangraham wants to merge 3 commits into
Open
pkp/pkp-lib#12509 Add Crossref support for peer review DOIs#93taslangraham wants to merge 3 commits into
taslangraham wants to merge 3 commits into
Conversation
taslangraham
force-pushed
the
i12509-main
branch
5 times, most recently
from
be1739b to
faaf5f8
Compare
bozana
reviewed
Jun 3, 2026
bozana
left a comment
bozana
left a comment
Contributor
There was a problem hiding this comment.
Hi @taslangraham, see my comments/questions...
| $publication = $this->getPublication($reviewAssignment); | ||
|
|
||
|
|
||
| $doiVersioning =$deployment->getContext()->getData(Context::SETTING_DOI_VERSIONING); |
Contributor
There was a problem hiding this comment.
empty space between = and the code is missing
| foreach ($this->reviewAssignments as $reviewAssignment) { | ||
| $this->reviewRounds->put( | ||
| $reviewAssignment->getReviewRoundId(), | ||
| $reviewRoundDao->getById($reviewAssignment->getReviewRoundId()) |
Contributor
There was a problem hiding this comment.
This makes one DB query per review assignment. It should rather batch-load all review rounds at once, similar to how loadPublications and loadReviewers do.
Maybe/probably you would need to implement such a function in that DAO, but maybe it is worth it?
What do you think?
Contributor
Author
There was a problem hiding this comment.
Good idea, and yes, a new method will need to be added to the DAO; I'll go ahead and implement your suggestion.
taslangraham
force-pushed
the
i12509-main
branch
2 times, most recently
from
82be03c to
e8d37d0
Compare
taslangraham
force-pushed
the
i12509-main
branch
from
e8d37d0 to
3fb6a07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For pkp/pkp-lib#12509