Fix FilterGroup::GetFramebuffer/SetFramebuffer dead delegation - #241
Open
avosa wants to merge 1 commit into
Open
Fix FilterGroup::GetFramebuffer/SetFramebuffer dead delegation#241avosa wants to merge 1 commit into
avosa wants to merge 1 commit into
Conversation
FilterGroup::GetFramebuffer() always returns null and SetFramebuffer() is a no-op: both bodies delegate to terminal_filter_ but the actual calls are commented out. Any consumer holding a FilterGroup subclass (BeautyFaceFilter, FaceReshapeFilter, etc. by way of their shared base) and calling GetFramebuffer() on it gets null even after a successful render, since the group's own framebuffer_ member is never populated - only its internal terminal filter's is. Uncommented both delegations. AddSink/DoUpdateSinks are unaffected (they already route through terminal_filter_ correctly), so this only fixes the direct accessor path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetFramebuffer() always returns null and SetFramebuffer() is a no-op: both bodies delegate to terminal_filter_, but the actual calls are commented out. Any consumer holding a FilterGroup subclass (BeautyFaceFilter, FaceReshapeFilter, and anything else built on FilterGroup) and calling GetFramebuffer() on it gets null even right after a successful render, since the group's own framebuffer_ member is never populated - only its internal terminal filter's is.
Uncommented both delegations. AddSink/DoUpdateSinks already route through terminal_filter_ correctly and are unaffected; this only fixes the direct accessor path.
Found while building a GPU compositing bridge on top of BeautyFaceFilter's output - GetFramebuffer() silently returning null was the first symptom.