Repository navigation
fix(web): a quick retry on a sidebar thread row opens it - #26550
Draft
makhnatkin wants to merge 1 commit into
Draft
makhnatkin wants to merge 1 commit into
makhnatkin wants to merge 1 commit into
Conversation
macOS reports clicks at the same spot within the double-click interval with detail > 1, so a retry after a lost click was dropped as the trailing click of a double-click. Only the open row now skips it, which keeps double-click rename intact. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
added
vouch:unvouched
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI-generated
"Generated" means mostly the model, "Edited" means mostly me.
Problem
On macOS, a retry on a sidebar thread row within the double-click interval does nothing. macOS keeps counting clicks at one spot, so the retry arrives with
detail > 1, and the row skips every such click as the trailing click of a double-click. When the first click is lost, each quick retry is lost too. Refs #22058, cause described in this comment.Change
The row skips a click with
detail > 1only when it is already the open thread. A quick retry on a row that is not open opens it. Double-click rename keeps working: the first click opens the row, and the trailing click on the now open row is skipped.Scope and approval
Focused fix for the cause above: one helper in
Sidebar.logic.tsand its use in the row click handler. The chat header title keeps its owndetail > 1guard.Verification
Added a table to
Sidebar.logic.test.tsforshouldNavigateOnThreadClick:detail2 and 3 on a row that is not open navigate,detail2 on the open row does not.Not run yet:
vp test run apps/web/src/components/Sidebar.logic.test.ts, and a manual check of double-click rename and quick retries in a packaged build.Written with Claude Opus 5.5 in Claude Code (via T3 Code).
🤖 Generated with Claude Code