Skip to content

fix(web): clarify fast mode availability in settings - #15132

Closed
mariusdill wants to merge 1 commit into
pingdotgg:mainfrom
mariusdill:fix/model-capability-label
Closed

mariusdill wants to merge 1 commit into
pingdotgg:mainfrom
mariusdill:fix/model-capability-label

Conversation

@mariusdill

Copy link
Copy Markdown

Provider settings currently show Fast mode whenever a model offers a speed option, even when Fast mode is off. This looks like an active setting. The label now says Fast mode available to describe the capability accurately.

This is a small wording fix for an obvious ambiguity. Capability detection, model defaults, picker visibility, and runtime settings are unchanged. The composer continues to describe active Fast mode separately. Web and desktop share this component; mobile has no equivalent capability label.

Verification:

  • A temporary Node assertion against the actual capability-description function failed before the fix and passed afterwards with fastMode.currentValue both false and true.
  • vp test run --project unit src/components/settings/ProviderModelsSection.test.ts: 3 tests passed (existing ordering and bulk visibility coverage).
  • vp exec tsc --noEmit in apps/web: passed.
  • Targeted vp lint and vp fmt --check: passed; lint reports an existing effect-dependency warning on line 224.
  • Before/after captures render the actual ProviderModelsSection in a temporary Vite harness at 1280 × 800 with Fast mode off. The harness was removed and is not committed. Full app navigation, narrow layouts, and the installed desktop build were not tested.
  • Independent read-only review by Opus 5.5 (high): no concrete defects found.

Before:
Before: Fast mode label with Fast mode off

After:
After: Fast mode available label with Fast mode off

Made by GPT-6.1 Sol (medium) in T3 Code through the Codex harness.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 3, 2026
@mariusdill mariusdill closed this Oct 3, 2026
@mariusdill
mariusdill deleted the fix/model-capability-label branch October 3, 2026 10:08
@macroscopeapp

macroscopeapp Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 7d79245

Macroscope's review found this PR approvable — This PR only clarifies an existing settings label from “Fast mode” to “Fast mode available.” Capability detection, defaults, and runtime behavior remain unchanged, making the change a small, isolated UI wording adjustment.

You can add or adjust custom eligibility rules. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant