fix(web): clarify fast mode availability in settings - #15132
Closed
mariusdill wants to merge 1 commit into
Closed
mariusdill wants to merge 1 commit into
mariusdill wants to merge 1 commit into
Conversation
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This PR only clarifies an existing settings label from “Fast mode” to “Fast mode available.” Capability detection, defaults, and runtime behavior remain unchanged, making the change a small, isolated UI wording adjustment. You can add or adjust custom eligibility rules. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provider settings currently show
Fast modewhenever a model offers a speed option, even when Fast mode is off. This looks like an active setting. The label now saysFast mode availableto describe the capability accurately.This is a small wording fix for an obvious ambiguity. Capability detection, model defaults, picker visibility, and runtime settings are unchanged. The composer continues to describe active Fast mode separately. Web and desktop share this component; mobile has no equivalent capability label.
Verification:
fastMode.currentValueboth false and true.vp test run --project unit src/components/settings/ProviderModelsSection.test.ts: 3 tests passed (existing ordering and bulk visibility coverage).vp exec tsc --noEmitinapps/web: passed.vp lintandvp fmt --check: passed; lint reports an existing effect-dependency warning on line 224.ProviderModelsSectionin a temporary Vite harness at 1280 × 800 with Fast mode off. The harness was removed and is not committed. Full app navigation, narrow layouts, and the installed desktop build were not tested.Before:

After:

Made by GPT-6.1 Sol (medium) in T3 Code through the Codex harness.