[Bug]: Android connection switch taps expand the row instead of enabling the environment

[JerkyTreats]

Before submitting

• I searched existing issues and did not find a duplicate of this tap behavior.
• I included enough detail to reproduce or investigate the problem.

Area

apps/mobile

Steps to reproduce

1. Use the Android mobile app with a saved direct connection to a compatible T3 Code server.
2. Switch the connection off, then open its connection settings.
3. Confirm that the row says Off, rather than Client not supported.
4. Tap the connection switch itself.
5. Repeat with the details collapsed and expanded.

Expected behavior

Tapping the enabled switch turns the saved connection on. Tapping the label or chevron separately opens or expands its details.

Actual behavior

Tapping the switch expands or collapses the connection row instead. The switch stays off and the connection is not enabled.

This remained reproducible after restarting the app cleared an earlier protocol-compatibility block. The remaining Off state had no compatibility error.

Impact

Major degradation or frequent failure. The saved connection cannot be enabled through its switch.

Version or commit

Reproduced on an Android 2.0.0 production build of a local fork. Checked upstream main at 8ed276c246b624631e7d39241ebfd22d8314cb68.

The following three upstream files are byte-for-byte identical to the files in the reproduced build. A stock upstream APK has not been separately runtime-tested.

• ConnectionEnvironmentRow.tsx
• CloudEnvironmentRows.tsx
• MaterialSwitch.android.tsx

Environment

Physical Android device running Android 17. Saved direct connection. The Android switch is rendered through Expo UI Jetpack Compose.

Diagnosis and proposed fix

ConnectionEnvironmentRow places ThemedSwitch inside the row's React Native Pressable, whose onPress toggles row details. On Android, ThemedSwitch renders an Expo UI Compose switch through a native Host. The observed behavior is consistent with the ancestor pressable taking the tap instead of the native switch.

Use a non-interactive row container and keep the switch outside every row-navigation pressable:

<View className="flex-row items-center">
  <Pressable onPress={onToggleDetails}>
    {/* Label and connection status */}
  </Pressable>
  <ThemedSwitch value={enabled} onValueChange={onSetEnabled} />
  <Pressable onPress={onToggleDetails}>
    {/* Chevron */}
  </Pressable>
</View>

The same nested structure exists in ConnectedCloudEnvironmentRow: its outer pressable wraps a shell containing the native switch. Apply the same separation there, moving navigation and long-press removal onto the content and chevron. Cloud-row runtime reproduction has not been separately confirmed.

Keep the existing compatibility checks and disabled state for genuinely unsupported servers. Give each switch its own accessible connection label.

Validation of the proposed fix

The two row components were updated locally to make the switch a sibling of the row pressables. The rebuilt APK was installed on the same device, and the user confirmed that tapping the switch now triggers the toggle.

Formatting, lint, type checking, the full repository test gate, and the mobile static check passed. The Android release build and APK verification passed. This validates the locally patched build; it does not claim separate upstream APK acceptance.

Recommended native regression checks: direct-row switch taps in both expanded states, switching on and off, saved cloud-row switches, label and chevron navigation, cloud-row long-press removal, unsupported-server disabling, and iOS behavior.

Related reports considered

• #13266 describes desktop welcome-wizard handling of persisted disabled connections and re-pairing.
• #14252 describes the separate mobile activity toggle rolling back after a relay permission failure.

Neither describes connection-switch taps expanding a row without changing its enabled state.

[juliusmarminge]

Note

Grok responding on behalf of Julius.

Triage

Thanks for the clear report and the tested fix, @JerkyTreats! Confirmed on current main (8ed276c, the commit you checked). This is an Android touch-target bug. The connection stays off because the row's pressable gets the tap, not because of a compatibility or enablement failure.

ConnectionEnvironmentRow puts ThemedSwitch inside the Pressable whose onPress is onToggle, which expands the editor on the Connections screen and opens environment details from Settings. On Android, ThemedSwitch is the Expo UI Compose switch in MaterialSwitch.android.tsx, and its Host doesn't take the tap away from the ancestor pressable. So the row expands or collapses and onValueChange never runs. iOS uses the React Native Switch there, which does receive the tap.

ConnectedCloudEnvironmentRow has the same nesting: its outer pressable (open on press, remove on long-press) wraps CloudEnvironmentRowShell, which contains the switch. Unsaved cloud rows aren't wrapped that way, and the switches in Settings are already siblings of their labels, which is why those toggles work.

This is separate from #13266 (desktop welcome wizard) and #14252 (activity toggle rolling back after a relay permission failure).

A fix should keep every connection switch outside the pressable that expands, navigates, or removes the row, including saved cloud rows. Long-press removal should stay on the row content rather than the switch, and unsupported servers should stay disabled. Worth checking: switch on and off, collapsed and expanded, label and chevron still opening details, cloud-row long-press removal, and iOS.

Your fork APK result is enough to track this, since the three files you named still match main.

[atharvadeosthale]

Opened #15121 to fix this.

The cause is in MaterialSwitch.android.tsx. React Native's own Switch claims the touch responder so a surrounding Pressable never fires, but the Compose switch didn't. So the row's Pressable took the responder, and once a React Native view holds it, JSResponderHandler intercepts the touch and the native switch gets cancelled. That's why the row expands or opens details while the switch stays off.

The PR claims the responder on the Compose Host, which doesn't intercept touches. That fixes every Android switch inside a pressable row, including local and saved T3 Connect environment rows, without restructuring the rows. Before/after screenshots and recordings from a OnePlus 11 are in the PR.