Skip to content

Use writable /tmp TMPDIR for tests on both CI runners #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TeoSlayer merged 1 commit into from
Jun 22, 2026
Merged

Use writable /tmp TMPDIR for tests on both CI runners #316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 17 additions & 13 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,18 +44,22 @@ jobs:
# -short skips 3 known-slow stress tests in pkg/daemon and
# pkg/daemon/udpio; everything else runs.
#
# macOS runners hand out a $RUNNER_TEMP (/Users/runner/work/_temp)
# whose ACLs make t.TempDir() fail with "mkdir ...: permission
# denied" (a recurring GitHub macos-runner issue, seen on #304/
# #306/#308) — and a writable subdir under it inherits the same
# restriction, so pointing TMPDIR there is not enough. Use a fresh
# mktemp dir under /tmp instead, which is writable by the test
# process. Ubuntu keeps the default $RUNNER_TEMP behaviour.
# Both hosted runners have started handing out a $RUNNER_TEMP
# (/Users/runner/work/_temp on macOS, /home/runner/work/_temp on
# ubuntu) whose ACLs make t.TempDir() fail with "mkdir ...:
# permission denied" — a recurring GitHub-runner issue (seen on
# #304/#306/#308 for macOS and now hitting ubuntu too). A writable
# subdir under it inherits the same restriction, so redirecting
# TMPDIR *into* $RUNNER_TEMP is not enough; it must point at a
# freshly-created dir outside that tree. Create one under /tmp
# (writable by the test process on both Linux and macOS), chmod it
# so t.TempDir()'s sub-dirs are creatable, and point $TMPDIR there
# for THIS run block so go test's os.TempDir() -> t.TempDir()
# lands somewhere writable. No job/step-level `env: TMPDIR:` is set
# anywhere in this workflow, so nothing overrides this export.
run: |
if [ "${RUNNER_OS}" = "macOS" ]; then
TMPDIR="$(mktemp -d /tmp/gotmp.XXXXXX)"
export TMPDIR
else
export TMPDIR="${RUNNER_TEMP}"
fi
TMPDIR="$(mktemp -d /tmp/gotmpXXXXXX 2>/dev/null || mktemp -d "${RUNNER_TEMP:-.}/gotmpXXXXXX")"
chmod 777 "$TMPDIR"
export TMPDIR
echo "using TMPDIR=$TMPDIR"
go test -short -count=1 -timeout 600s ./pkg/... ./cmd/... ./internal/...
Loading