Repository navigation
build(rust): bump gpui-terminal to v0.2.2 - #638
Merged
Merged
Conversation
v0.2.2 ends a PTY child's whole process group on teardown: terminate() and Drop SIGHUP the child's group and the terminal's foreground group, then SIGKILL what is left after 500ms. An agent's descendants no longer outlive its terminal. The lockfile change is the gpui-terminal entry only (version, source, and the libc dependency it now takes, already locked at 0.2.190): `cargo update -p gpui-terminal` also re-picked windows-sys for unrelated packages, which is left out, as in #602. Closes #637 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
paulyhedral
enabled auto-merge
October 8, 2026 16:34
paulyhedral
disabled auto-merge
October 8, 2026 16:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes pilgrimagesoftware/Knot-App#198.
Bumps the
gpui-terminalgit dependency fromv0.2.1tov0.2.2(signed tag on master,d1a5f00).What v0.2.2 changes for Knot: when an agent's terminal is torn down (
TerminalSession::shutdown, window close, agent removal or restart),terminate()/Dropnow SIGHUP the child's whole process group and the PTY's foreground group, then SIGKILL anything still there after 500ms. Before, only the shell's own PID got SIGHUP, so a descendant that ignores SIGHUP, or runs in another job's group, could outlive its terminal. Knot needs no code change for this.Lockfile: only the
gpui-terminalentry changes: version, source, and its newlibcdependency, which is already locked at 0.2.190.cargo update -p gpui-terminalalso re-pickedwindows-sys0.61→0.60 for ten unrelated packages. I left that out, as #602 did.cargo metadata --lockedandmakepass, and there's still a singlegpui-kit0.7.0.#635's shutdown skip, checked against the new
terminate():TerminalSession::shutdown()skipterminate()once the shell has reported its exit, because v0.2.1'skillreturnedESRCH("No such process") on an exited child.terminate()handles this itself. It skips a reaped child, treatsESRCHfromkillpgas "already gone", and a zombie's group still accepts signals.terminate()after the exit was reported, and 20 racing the exit. All 40 returnedOk.Cargo.tomlandCargo.lock, and feat(knot-terminal): mark agent shells with KNOT_AGENT; hermetic PTY tests #635 touchesknot-terminal.Checks:
makepasses locally (fmt-check, size-check, declared-check, clippy, test, build).🤖 Generated with Claude Code