Repository navigation
1.4.2: take on an infinite source pulls lazily - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Stream(fromRange(1))->take(n)grew linearly withn(24.8 MB at 300k, 57 MB at 1M) becauseInfinitePulloverrodetake()to collect thenvalues into aValuesPullbefore the lazy compile path ever ran. The override now appends the haltingtaketransformation from 1.4.0, so the source is pulled one value at a time and stops aftern; theTimerbranch forawakeEveryis kept.Spec:
InfiniteTakeSpecchecks the first five values, composition with a followingmap, and 300,000 values throughevalTapanddrain()under 8 MB.Docs
Two guide links pointed at pages that do not exist (
stream-operations.md,../README.md).