Fix follow_redirect/3 doc example for regular redirects#4187
Open
preciz wants to merge 1 commit intophoenixframework:mainfrom
Open
Fix follow_redirect/3 doc example for regular redirects#4187preciz wants to merge 1 commit intophoenixframework:mainfrom
preciz wants to merge 1 commit intophoenixframework:mainfrom
Conversation
SteffenDE
reviewed
Apr 18, 2026
Comment on lines
1834
to
+1835
| assert {:error, {:redirect, %{to: "/somewhere"}}} = result = live(conn, "my-path") | ||
| {:ok, view, html} = follow_redirect(result, conn) | ||
| {:ok, conn} = follow_redirect(result, conn) |
Collaborator
There was a problem hiding this comment.
Maybe we adjust the error tuple to say :live_redirect instead, so the tuple is correct? I think live redirects are more common, so it makes more sense to for this example?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
:redirectthe return tuple offollow_redirectis{:ok, conn}.The 3 tuple is for
:live_redirect.So to match the previous line's logic this has to be the
{:ok, conn}.The function below that shows the correct return value:
phoenix_live_view/lib/phoenix_live_view/test/live_view_test.ex
Line 1862 in a7d9c36