Repository navigation
Comment on suggestions; icon card actions (#45) - #47
Merged
Merged
Conversation
A comment directly after an addition, deletion or substitution is now that suggestion's rationale: the panel shows it inside the suggestion card, and accept/reject removes it with the change. Suggestions without one get a Comment action. Card actions become icon buttons. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…hreads - Thread.changeIndex holds a change anchor; anchorIndex is highlight-only again - Resolving a change also removes the whitespace before its thread - Panel Accept/Reject confirms (per confirmBeforeDelete) when the thread has replies - Reuse isChangeNode / anchor maps instead of recomputing Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45.
docs/SKILL.md,CLAUDE.mdandREADME.mdare updated.Existing notes change behaviour: a comment already sitting right after a suggestion now belongs to it and is removed when the suggestion is resolved.
Testing
npm run buildandnpm testpass. New parser tests cover anchoring for all three change kinds, gaps, AI-added text and highlight precedence. New operations tests coverappendComment, accept/reject taking the thread, rebasing after drift, the cursor commands, deleting a comment leaving the change alone, and finalize.Not yet tested manually in Obsidian. The test note is
TestingNotes/track-changes/suggestion-comments.md.🤖 Generated with Claude Code