Skip to content

Revert "Delete spinning file" because this file is still referenced#1144

Open
bluntelk wants to merge 1 commit into
phiamo:masterfrom
bluntelk:master
Open

Revert "Delete spinning file" because this file is still referenced#1144
bluntelk wants to merge 1 commit into
phiamo:masterfrom
bluntelk:master

Conversation

@bluntelk

Copy link
Copy Markdown

and required

This reverts commit 7a3b15c.

@bluntelk

Copy link
Copy Markdown
Author

This is a simple commit to revert a change that is causing grief for users using Font Awesome LESS files

@phiamo

phiamo commented Jan 4, 2016

Copy link
Copy Markdown
Owner

no sure what this is for ;-) could you explain the use case a bit ?
thanks for this contribution

@bluntelk

bluntelk commented Jan 4, 2016

Copy link
Copy Markdown
Author

Hi @phiamo

Sure. This commit is simply reverting a deleted file (spinning.css).

This file is still referenced by
https://github.com/phiamo/MopaBootstrapBundle/blob/master/Resources/public/less/font-awesome4/font-awesome.less

For LESS users, this is causing the assets to fail when dumping. We then get broken CSS and no styling.

@bluntelk

bluntelk commented Jan 7, 2016

Copy link
Copy Markdown
Author

Hi @phiamo

Any chance of having this PR merged?

@phiamo

phiamo commented Feb 3, 2017

Copy link
Copy Markdown
Owner

@isometriks do you see chances this could break anything ?

@isometriks

Copy link
Copy Markdown
Collaborator

Nope, should be fine. Although I plan on removing any embedded libraries in this repo, so I would suggest against anybody using it this way anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants