Skip to content

replace shortened URLs using goo.gl - #9001

Closed
mcepl wants to merge 1 commit into
pgadmin-org:masterfrom
openSUSE-Python:no-goo_gl
Closed

replace shortened URLs using goo.gl#9001
mcepl wants to merge 1 commit into
pgadmin-org:masterfrom
openSUSE-Python:no-goo_gl

Conversation

@mcepl

@mcepl mcepl commented Jul 28, 2025

Copy link
Copy Markdown
Contributor

@adityatoshniwal

Copy link
Copy Markdown
Contributor

@mcepl why do we need this?

@mcepl

mcepl commented Jul 29, 2025

Copy link
Copy Markdown
Contributor Author

Because on 2025-08-25 all those links you have in your code (and somebody supposedly put them for a purpose) will lead to “No server found” error.

@adityatoshniwal

Copy link
Copy Markdown
Contributor

Because on 2025-08-25 all those links you have in your code (and somebody supposedly put them for a purpose) will lead to “No server found” error.

lets use https://tinyurl.com/

@mcepl

mcepl commented Jul 29, 2025

Copy link
Copy Markdown
Contributor Author

I just don’t use shorteners any more if at all possible (that's what I did in most my submissions like this; I did more of them yesterday; yes, there are some URLs which are just impossible to use in full length, but none of them in pgadmin4). https://www.w3.org/Provider/Style/URI (check the copyright date of that page), and every shortener is an implied code debt, something which you have to check and follow whether it is not broken.

@adityatoshniwal

Copy link
Copy Markdown
Contributor

I just don’t use shorteners any more if at all possible (that's what I did in most my submissions like this; I did more of them yesterday; yes, there are some URLs which are just impossible to use in full length, but none of them in pgadmin4). https://www.w3.org/Provider/Style/URI (check the copyright date of that page), and every shortener is an implied code debt, something which you have to check and follow whether it is not broken.

The link which you updated fails the PEP8 checks and we cannot break links to multi lines.

@mcepl

mcepl commented Jul 29, 2025

Copy link
Copy Markdown
Contributor Author

Just do whatever you want to do with this PR: change it, reject it, modify it, whatever. I off to do something more useful.

@adityatoshniwal

Copy link
Copy Markdown
Contributor

Just do whatever you want to do with this PR: change it, reject it, modify it, whatever. I off to do something more useful.

I would like to merge it definitely - but the pep8 check (python linter) is failing. I can't merge if this is not fixed unfortunately.

@dpage

dpage commented Jul 29, 2025

Copy link
Copy Markdown
Contributor

Just use tinyurl @adityatoshniwal. It's only one URL after all.

Thank you for the PR @mcepl .

@adityatoshniwal

Copy link
Copy Markdown
Contributor

Just use tinyurl @adityatoshniwal. It's only one URL after all.

Thank you for the PR @mcepl .

Here a197c85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants