Skip to content

Fix non concatenation history observation handling case#1

Open
maks-bdai wants to merge 2 commits into
pculbertson/history_obs_bugfixfrom
maks-bdai/history_obs_non_concat_hist_fix
Open

Fix non concatenation history observation handling case#1
maks-bdai wants to merge 2 commits into
pculbertson/history_obs_bugfixfrom
maks-bdai/history_obs_non_concat_hist_fix

Conversation

@maks-bdai

Copy link
Copy Markdown
Collaborator

Change

  • Moved concatenation check to beginning of function for early return
  • Added a test to verify that the observation group with concat disabled works as expected

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant