fix(archive): reject unsupported formats - #110
Open
pttydou wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #97.
Validates
formatduring YAML loading so unsupported values return a configuration error instead of calling a nil archive constructor. Adds a regression test forformat: rar.Types of changes
Checklist
Test plan
go test ./internal/pkg/pipeline/task/archive -count=1go test ./... -count=1— the archive package passes, but the full command cannot compile the existingconfluent-kafka-godependency on Windows withCGO_ENABLED=0(undefined: kafka.LibraryVersion). Linux CI covers the remaining build.