Skip to content

fix(archive): reject unsupported formats - #110

Open
pttydou wants to merge 1 commit into
patterninc:mainfrom
pttydou:fix/archive-format-validation
Open

fix(archive): reject unsupported formats#110
pttydou wants to merge 1 commit into
patterninc:mainfrom
pttydou:fix/archive-format-validation

Conversation

@pttydou

@pttydou pttydou commented Aug 23, 2026

Copy link
Copy Markdown

Description

Fixes #97.

Validates format during YAML loading so unsupported values return a configuration error instead of calling a nil archive constructor. Adds a regression test for format: rar.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Test plan

  • go test ./internal/pkg/pipeline/task/archive -count=1
  • go test ./... -count=1 — the archive package passes, but the full command cannot compile the existing confluent-kafka-go dependency on Windows with CGO_ENABLED=0 (undefined: kafka.LibraryVersion). Linux CI covers the remaining build.

@pttydou
pttydou requested a review from a team as a code owner August 23, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

archive: unrecognized format panics at runtime

1 participant