Remove stale Alice-specific override in Slack alert logic - #22
Merged
Sagar Chaudhari (Sagar-Pattern) merged 1 commit intoJul 17, 2026
Merged
Conversation
Copilot started reviewing on behalf of
Yash Dinesh Singh (ydsingh97)
July 17, 2026 06:09
View session
There was a problem hiding this comment.
Pull request overview
This PR simplifies the Slack failure alert formatter by removing a stale, person-specific override so that message content is driven by task characteristics (e.g., sensors) rather than an “alice” substring rule.
Changes:
- Removed the special-case
"alice"branching that changed emoji/message text. - Left the existing
"sensor"heuristic as the remaining special-case for potential data delay messaging.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -26,12 +26,7 @@ def base_failure_alert(context, conn): | |||
| _environment = f"Environment: *{environment.upper()}* - " if environment else "\b" | |||
Sagar Chaudhari (Sagar-Pattern)
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the outdated
alice-specific if/else override in the Slack alert formatter.