Repository navigation
build(Felt): migrate tasks and prereleases to Nx - #12687
gabipodolnikova wants to merge 6 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
| "test": { "semverBump": "patch" }, | ||
| "style": { "semverBump": "patch" }, | ||
| "build": { "semverBump": "patch" }, | ||
| "ci": { "semverBump": "patch", "changelog": false } |
There was a problem hiding this comment.
Confirming these are ok @kmcfaul @wise-king-sullyman?
| "projectChangelogs": true | ||
| }, | ||
| "git": { | ||
| "commitMessage": "chore(release): releasing packages [ci skip]", |
There was a problem hiding this comment.
Do we need the message if we are not committing anything?
What: Migrates Felt React task execution and the prerelease CI workflow from Lerna to Nx for FELT-144.
Draft: docs/chore policy is agreed and implemented. Remaining commit-type policy is still being aligned with the Core migration.
Implementation
@nx/jsto 24.0.0 and replace root Lerna task commands with Nx.prereleasebumps, preserving each selected package’s existing counter (for example,.3→.4).{projectName}@{version}Git tags and release commit subject,chore(release): releasing packages [ci skip]..release/bundle, including hidden files, before publishing through Nx using the existing npm trusted-publishing/OIDC setup. A missing expected artifact fails the upload step.Behavior changes and discussion points
docs:triggers release discovery so downstream consumers receive documentation updates, but is hidden from changelogs (semverBump: patch,changelog: false). Ordinarychore:commits neither independently trigger a release nor appear in changelogs (semverBump: none,changelog: false). Selected prerelease packages still increment their existing counters.fixandfeatuse the native Nx defaults. The current overrides forrefactor,perf,test,style,build, andcistill trigger release discovery and appear in changelogs; alignment of those types remains open.__INVALID__should appear under “Uncategorized changes” without triggering a bump. Valid but unconfigured types such asmisc:are separate from__INVALID__.demo-app-tsis intentionally excluded from release version bumps.origin; local fork rehearsals can pass--git-remote=upstream.felt-v1concurrency group. New merges no longer automatically cancel an active publication. GitHub may replace pending runs; this does not promise a separate release for every merge. Manual cancellation during publishing can still leave a partial release.Publishing-only recovery
A manual run of the same
release.ymlworkflow onfelt-v1takes the failed workflow run ID, downloads itsnx-release-packagesartifact, and checks out the recorded release commit. It installs dependencies without rebuilding packages, then publishes the prepared versions.felt-v1. Older releases are rejected before publication to prevent moving the npmprereleasetag backward.felt-v1, for example:gh workflow run release.yml --repo patternfly/patternfly-react --ref felt-v1 -f publish-only-run-id=RUN_ID. The Actions UI dispatch button depends on the default-branch workflow definition; GitHub-hosted invocation still needs verification.Testing
.2to.3.follow-up: