feat(icons): update close icons to use the rh micron#12283
Open
wise-king-sullyman wants to merge 1 commit intopatternfly:mainfrom
Open
feat(icons): update close icons to use the rh micron#12283wise-king-sullyman wants to merge 1 commit intopatternfly:mainfrom
wise-king-sullyman wants to merge 1 commit intopatternfly:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (18)
📒 Files selected for processing (37)
WalkthroughThis PR systematically replaces all instances of Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can enable review details to help with troubleshooting, context usage and more.Enable the |
Collaborator
|
Preview: https://pf-react-pr-12283.surge.sh A11y report: https://pf-react-pr-12283-a11y.surge.sh |
wise-king-sullyman
requested review from
a team,
dlabaj and
nicolethoen
and removed request for
a team
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
There's some areas that need the icon updated still:
- Button examples ButtonVariations, ButtonDisabled, and ButtonCircle + example MD
- ActionList examples ActionListVertical, ActionListWwithIcons + example MD
- HelperText example HelperTextWithCustomIcon + example MD
- There's also a few demo MD files that are importing the TimesIcon still that I'm not sure if we need? Toolbar, HelperText, and CustomMenus MD files
nicolethoen
reviewed
Mar 25, 2026
Contributor
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
Nothing to note from me other than Eric's comment and the conflict ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #12262
Additional issues:
Summary by CodeRabbit
Release Notes
Style