Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughA Helm repository index was updated with a new chart entry for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
helm-releases/index.yaml (1)
1-1591: Generate helm-releases/index.yaml from the release script to prevent drift.The
helm-reindex.shscript packages charts intohelm-releases/but only indexes the root directory. This creates two independently versioned Helm repository indexes with different timestamps, increasing the risk of metadata divergence. Add a second indexing command to regeneratehelm-releases/index.yaml:🔧 Suggested workflow change
#!/bin/bash helm package helm -d helm-releases/ helm repo index --merge index.yaml --url https://charts.parseable.com . +helm repo index --url https://charts.parseable.com/helm-releases helm-releases/🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@helm-releases/index.yaml` around lines 1 - 1591, The repo currently generates a Helm index only for the root (via the release script) causing helm-releases/index.yaml to drift; update the release workflow/script (helm-reindex.sh) to run helm repo index --merge (or helm repo index) against the helm-releases/ directory after packaging so that helm-releases/index.yaml is regenerated from the packaged charts, ensuring a single authoritative index file; locate the packaging step in helm-reindex.sh (the section that packages charts into helm-releases/) and append a second indexing call that writes/overwrites helm-releases/index.yaml (use the same flags as the root indexing call to preserve digests/timestamps).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@helm-releases/index.yaml`:
- Around line 1579-1589: Update the unreachable .io chart URLs for the
parseable-operator entries: locate the parseable-operator index entries (name:
parseable-operator, version: 0.1.0 and appVersion: 0.0.1 block) and either
replace the urls entries that point to
https://charts.parseable.io/helm-releases/... with
https://charts.parseable.com/helm-releases/... or remove those url lines
entirely if those versions are deprecated; ensure the digest/name/version fields
remain consistent after the change.
---
Nitpick comments:
In `@helm-releases/index.yaml`:
- Around line 1-1591: The repo currently generates a Helm index only for the
root (via the release script) causing helm-releases/index.yaml to drift; update
the release workflow/script (helm-reindex.sh) to run helm repo index --merge (or
helm repo index) against the helm-releases/ directory after packaging so that
helm-releases/index.yaml is regenerated from the packaged charts, ensuring a
single authoritative index file; locate the packaging step in helm-reindex.sh
(the section that packages charts into helm-releases/) and append a second
indexing call that writes/overwrites helm-releases/index.yaml (use the same
flags as the root indexing call to preserve digests/timestamps).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 0b16704b-d06c-43e8-aa7f-645e7cbe7e3b
📒 Files selected for processing (2)
helm-releases/index.yamlhelm-releases/pai-0.2.0.tgz
helm-releases/index.yaml
Outdated
| - https://charts.parseable.io/helm-releases/parseable-operator-0.1.0.tgz | ||
| version: 0.1.0 | ||
| - apiVersion: v2 | ||
| appVersion: 0.0.1 | ||
| created: "2023-04-16T15:34:14.37528+05:30" | ||
| description: A Helm chart for Parseable Operator | ||
| digest: e3a5075a3d753acc58f8a4d6003c333c5edf2b3976e1e678188c9d6ff48f1b63 | ||
| name: parseable-operator | ||
| type: application | ||
| urls: | ||
| - https://charts.parseable.io/helm-releases/parseable-operator-0.0.1.tgz |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Verify mixed hosts present in this index
rg -n 'https://charts\.parseable\.(com|io)/helm-releases/' helm-releases/index.yaml
# Validate reachability of parseable-operator URLs currently listed
while read -r url; do
code=$(curl -sS -o /dev/null -w "%{http_code}" -I "$url")
echo "${code} ${url}"
done < <(rg -o 'https://charts\.parseable\.io/helm-releases/parseable-operator-[0-9.]+\.tgz' helm-releases/index.yaml)Repository: parseablehq/parseable
Length of output: 5863
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Test reachability of parseable-operator URLs
echo "Testing parseable-operator URLs:"
echo ""
# Test .io URLs
echo "Testing .io domain:"
curl -sS -o /dev/null -w "%{http_code} - parseable-operator-0.1.0 (.io)\n" -I "https://charts.parseable.io/helm-releases/parseable-operator-0.1.0.tgz" || echo "FAILED - parseable-operator-0.1.0 (.io)"
curl -sS -o /dev/null -w "%{http_code} - parseable-operator-0.0.1 (.io)\n" -I "https://charts.parseable.io/helm-releases/parseable-operator-0.0.1.tgz" || echo "FAILED - parseable-operator-0.0.1 (.io)"
echo ""
echo "Testing .com domain (for comparison):"
# Test .com URLs for other charts
curl -sS -o /dev/null -w "%{http_code} - parseable-2.5.13 (.com)\n" -I "https://charts.parseable.com/helm-releases/parseable-2.5.13.tgz" || echo "FAILED - parseable-2.5.13 (.com)"
curl -sS -o /dev/null -w "%{http_code} - operator-0.0.3 (.com)\n" -I "https://charts.parseable.com/helm-releases/operator-0.0.3.tgz" || echo "FAILED - operator-0.0.3 (.com)"Repository: parseablehq/parseable
Length of output: 494
Remove or correct unreachable .io chart URLs in parseable-operator entries.
Lines 1579 and 1589 reference https://charts.parseable.io/helm-releases/, which is unreachable (DNS resolution fails). All other charts in this index use https://charts.parseable.com/. The .io domain is completely inaccessible, making parseable-operator versions 0.1.0 and 0.0.1 unavailable to users. Update these lines to use the .com domain or remove them if these versions are no longer supported.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@helm-releases/index.yaml` around lines 1579 - 1589, Update the unreachable
.io chart URLs for the parseable-operator entries: locate the parseable-operator
index entries (name: parseable-operator, version: 0.1.0 and appVersion: 0.0.1
block) and either replace the urls entries that point to
https://charts.parseable.io/helm-releases/... with
https://charts.parseable.com/helm-releases/... or remove those url lines
entirely if those versions are deprecated; ensure the digest/name/version fields
remain consistent after the change.
1 participant
Summary
Summary by CodeRabbit