CI validation: drop-sudo socket ACL fix - #1
Closed
pardhaponugoti wants to merge 1 commit into
Closed
Conversation
…ping group/other mode bits restrictRootServiceSocket previously chmod-ed every root-owned service socket the runner user could write to `mode & 0o700`. On a live host that removes access for the system peers those sockets exist to serve — D-Bus clients such as systemd-resolved, journald stdout connections, docker group members. systemd-resolved (a non-root service) then fails to (re)start with "Failed to connect to system bus: Permission denied", crash-loops into the systemd start limit, and name resolution dies machine-wide. On GitHub-hosted runners this eventually starves the runner agent itself: jobs whose codex step exceeds ~45 minutes are declared "the hosted runner lost communication with the server" (observed 52-65 min across both standard and larger runners). Deny only the runner user instead, with a named-user ACL entry (setfacl -m u:<user>:---), leaving the socket mode — and therefore every system peer's access — untouched. Named-user entries also close the case a mode-only check missed: a socket whose group/other bits are already 0 but which grants the runner access through an existing ACL. When ACL tooling is unavailable the previous chmod behavior is kept as a fallback, so the security posture never regresses. The existing test contract is access-based (the fake codex binary records accessSync(W_OK) per socket) and passes unchanged; verification in the non-root phase continues to assert the dropped user cannot write any discovered socket. Fixes openai#160
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intra-fork PR to run the sudo-gated test suite before upstreaming.