Open
Conversation
ndellosa95
commented
Apr 22, 2026
Contributor
Author
ndellosa95
left a comment
ndellosa95
left a comment
There was a problem hiding this comment.
Some review comments of my own
| # ----------------------------------------------------------------------------------------------- | ||
|
|
||
|
|
||
| class DataclassOption(_OptionBase[_OptT, _DefaultT]): |
Contributor
Author
There was a problem hiding this comment.
I can break this out into a separate PR if desirable
| if cast(DockerPackageFieldSet, request.field_set).pushes_on_package(): | ||
| if ( | ||
| cast(PublishDockerImageFieldSet, request.field_set).pushes_on_package() | ||
| or options.build_engine == DockerBuildEngine.BUILDCTL |
Contributor
Author
There was a problem hiding this comment.
Should I maybe actually add buildctl as a push_engine option for this? Or in fact, maybe it doesn't make sense to have build_engine and push_engine as separate options?
| mutually_exclusive_group="engines", | ||
| ) | ||
|
|
||
| def _experimental_enable_podman_warning[ |
Contributor
Author
There was a problem hiding this comment.
This deprecates the experimental_enable_podman field while preserving backwards compat, at least for some period of time.
| for build_arg in build_args: | ||
| args.extend(["--opt", f"build-arg:{build_arg}"]) | ||
|
|
||
| if self._special_output_handling(output): |
Contributor
Author
There was a problem hiding this comment.
This is the aforementioned special --output field handling I mentioned in the PR description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23030
FYI I'm holding off on writing release notes until some of the implementation questions I've raised here are discussed.
It's worth discussing the default behavior for the
outputfield here.For the
dockerbuild engine, we just default to not including it if it's not provided. If it is provided, we just include it as is and leave the users responsible for whether the value makes sense.For the
buildctlbuild engine, we actually need the--outputoption, so there is a special handling function to determine we need to partially or completely generate the value OR if we should just provide it as is, same as thedockerway and leave it up to the user to make it make sense.