Skip to content

feat(IT-Wallet): [SIW-4177] Track third channel credentials#8082

Open
riccardosacco99 wants to merge 8 commits intomasterfrom
SIW-4177-tracking-third-channel-credentials
Open

feat(IT-Wallet): [SIW-4177] Track third channel credentials#8082
riccardosacco99 wants to merge 8 commits intomasterfrom
SIW-4177-tracking-third-channel-credentials

Conversation

@riccardosacco99
Copy link
Copy Markdown
Collaborator

Short description

This PR adds the new IT Wallet Mixpanel property ITW_THIRD_PARTY_CREDENTIAL, tracked both as a Super Property and a Profile Property. The property summarizes whether the user owns at least one credential obtained through the third-party/catalogue channel and whether at least one of those credentials is currently valid.

List of changes proposed in this pull request

  • Add ITW_THIRD_PARTY_CREDENTIAL to IT Wallet analytics base properties.
  • Compute the property as:
    • not_available when no third-party/catalogue credential is present.
    • valid when at least one third-party/catalogue credential is valid.
    • not_valid when third-party/catalogue credentials are present but none are valid.
  • Exclude PID and historical L2 credentials from the third-party aggregate calculation.
  • Keep the property synced on full analytics sync and after credential store/remove operations.
  • Reset the property to not_available when wallet analytics properties are reset.
  • Add unit tests for property calculation, profile/super updates, and credential store/remove saga updates.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

Jira Pull Request Link

This Pull Request refers to Jira issues:

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

❌ Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 61.73%. Comparing base (ef3221c) to head (a8ef848).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...wallet/analytics/properties/basePropertyBuilder.ts 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8082      +/-   ##
==========================================
- Coverage   61.73%   61.73%   -0.01%     
==========================================
  Files        1904     1903       -1     
  Lines       36199    36212      +13     
  Branches     5989     5991       +2     
==========================================
+ Hits        22347    22354       +7     
- Misses      12529    12534       +5     
- Partials     1323     1324       +1     
Files with missing lines Coverage Δ
...res/itwallet/analytics/properties/propertyTypes.ts 100.00% <ø> (ø)
.../itwallet/analytics/properties/propertyUpdaters.ts 66.66% <100.00%> (+3.80%) ⬆️
...llet/analytics/saga/credentialAnalyticsHandlers.ts 72.72% <100.00%> (+4.30%) ⬆️
ts/features/itwallet/analytics/utils/types.ts 100.00% <ø> (ø)
...wallet/analytics/properties/basePropertyBuilder.ts 95.23% <90.00%> (-1.64%) ⬇️

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef3221c...a8ef848. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant