Add HubrisArchive::load_from_path#674
Merged
Merged
Conversation
labbott
commented
May 21, 2026
| inlined | ||
| } | ||
|
|
||
| pub fn load_from_path<P: AsRef<Path> + std::fmt::Debug + Copy>( |
Contributor
Author
There was a problem hiding this comment.
The parameter was borrowed from hubtools, certainly open to suggestions
Contributor
There was a problem hiding this comment.
I'm the person who wrote them in hubtools, but cannot fathom why I added Copy as a bound here. I opened oxidecomputer/hubtools#66
For library functions this is a nice shortcut if we don't need to directly manipulate the `RawHubrisArchive`
labbott
force-pushed
the
labbott/load_from_path
branch
from
7a31cde to
0d41ea7
Compare
mkeeter
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For library functions this is a nice shortcut if we don't need to directly manipulate the
RawHubrisArchive