fix the loop counter in the bash "way" - #868
Open
mrodozov wants to merge 1 commit into
Open
Conversation
jesmrec
force-pushed
the
master
branch
5 times, most recently
from
September 17, 2025 10:09
909d26d to
4ef31b0
Compare
jesmrec
force-pushed
the
master
branch
5 times, most recently
from
January 16, 2026 12:10
ccb393f to
d9af4a3
Compare
jesmrec
force-pushed
the
master
branch
3 times, most recently
from
March 18, 2026 12:51
94f43a5 to
9351a45
Compare
dj4oC
approved these changes
Jul 7, 2026
dj4oC
left a comment
dj4oC
left a comment
Contributor
There was a problem hiding this comment.
Replaces an explicit space-separated loop counter (for i in 1 2 3 ... 20) with bash brace expansion (for i in {1..20}) in the Hetzner oCIS deploy script.
Findings
Nothing blocking. Purely cosmetic/idiomatic change; loop bounds and behavior are unchanged (still 20 iterations, same 4s sleep and break condition).
Verdict
Approved
🤖 Automated review by Claude Code
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was reading this file and noticed this explicit counter, thought it needed improvement