fix(logger): guard fetchResource against unknown resource name#284
Open
WhereiamL wants to merge 1 commit into
Open
fix(logger): guard fetchResource against unknown resource name#284WhereiamL wants to merge 1 commit into
WhereiamL wants to merge 1 commit into
Conversation
logStorage[data.resource] is undefined for any resource key that has not logged a query, causing fetchResource to throw on .filter()/.slice(). Bail out early when there is no stored log for the requested resource.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
oxmysql:fetchResourcenet handler validates thatdata.resourceis a string, but never checks that it actually exists inlogStoragebefore indexing it:If
data.resourceis any string that isn't a known resource key,logStorage[data.resource]isundefinedand the.filter()call (search branch) throwsCannot read properties of undefined. The non-search branch then feedsundefinedintoresourceLog.slice()/resourceLog.lengthfurther down, which throws as well.This is gated behind
command.mysql, so it isn't a privilege issue, but a permitted user (or a UI request racing a resource that hasn't logged anything yet) can throw an unhandled exception in the handler.Fix
Resolve the log entry once and bail out early when the resource has no stored queries, before any access.