fix(web): bump react-fontawesome so icon animations work#803
Merged
Conversation
LibIcon maps the full set of Font Awesome v6 animation props (beat, fade, beatFade, bounce, shake, spin, spinPulse, spinReverse), but @fortawesome/react-fontawesome was pinned to ^0.1.19, which only supports the legacy spin and pulse props. The other animations were silently dropped, so notify's iconAnimation (and any LibIcon animation) had no effect. Bump react-fontawesome to ^0.2.0 so all the animation props LibIcon already passes are honored. fontawesome-svg-core is already ^6.3.0, so the animation keyframes are present. Verified with a production web build (tsc + vite); 0.2.x keeps the pulse prop, so no existing usage regresses. Closes overextended#788
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
LibIconmaps the full set of Font Awesome v6 animation props —beat,fade,beatFade,bounce,shake,spin,spinPulse,spinReverse— but@fortawesome/react-fontawesomewas pinned to^0.1.19, which only supports the legacyspinandpulseprops. Every other animation was silently dropped, sonotify'siconAnimation(and anyLibIconanimation) had no visible effect. This is the cause of #788.Bumping
@fortawesome/react-fontawesometo^0.2.0makes the wrapper honour all the animation propsLibIconalready passes.@fortawesome/fontawesome-svg-coreis already^6.3.0, so the animation keyframes are present — only the React wrapper was too old.Verified with a production web build (
tsc && vite build) on react-fontawesome0.2.6: it compiles cleanly and0.2.xstill types/accepts thepulseprop, so no existing usage regresses.Closes #788
Checklist