Repository navigation
Conversation
…erator `parse_attribute_selector` chose the boxed node, the only attribute node with a namespace field, when the selector had a namespace and an uppercase letter in its name. A lowercase name such as `href` took the node for no namespace, so `[xl|href$=".pdf"]` printed as `[href$=".pdf"]` and merged with a real `[href$=".pdf"]` rule. Choose the node from the namespace alone, as the `[ns|name]` form already does. A name with an uppercase letter and no namespace stays in the inline node, so its minified output does not change.
Both constructors of the boxed node pass a namespace. Store it as a plain `NamespaceConstraint` and rename the node to `AttrSelectorWithNamespace`. A boxed node with no namespace no longer type-checks, and the node is 8 bytes smaller.
Collaborator
Author
Collaborator
Author
|
Status: closed. The fix landed in #47025 (7942008), which took the predicate and four tests from this PR. Verified on main at 7942008 echo '@namespace xl "urn:example:xlink";' > in.css
echo '[xl|href$=".pdf"] { color: red }' >> in.css
echo '[*|href^="http"] { color: blue }' >> in.css
echo 'use[xl|href="#i"] { color: green }' >> in.css
echo 'a[xl|href] { color: black }' >> in.css
bun build ./in.css --outdir out > /dev/null; grep href out/in.css
|
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 5 minutes. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe parser now represents namespaced attribute selectors with a required namespace constraint and routes namespaced value selectors through that representation regardless of attribute-name casing. Tests cover selector processing, ChangesNamespaced CSS Attribute Selectors
Suggested reviewers: Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Linked Issues check |  |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Title check | |
The title clearly and concisely describes the primary change: preserving namespace prefixes on attribute selectors with operators. |
| Description check | |
The description explains the problem, root cause, fix, scope, limitations, and verification results. It does not use the exact template headings, but it provides the required information in equivalent… |
Full details: Description check
-
Explanation
The description explains the problem, root cause, fix, scope, limitations, and verification results. It does not use the exact template headings, but it provides the required information in equivalent sections.
✨ Finishing Touches 💡 1
-
🛠️ Fix failing CI checks 💡
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Beyond the inline findings, I also checked two things and ruled them out: the minified esbuild snapshot prints [xl|href$=".pdf"] quoted while [href$=\.pdf] is ident-shortened — only the AttributeInNoNamespace arm of serialize_component in src/css/selectors/selector.rs does the ident/string shortening and AttributeOther goes through its own to_css, which matches lightningcss, so it is pre-existing rather than a regression. And the hash/eql change on the boxed node stays consistent: every constructor now supplies a namespace, so hashing it unconditionally cannot split equal selectors, and no reference to the old AttrSelectorWithOptionalNamespace name remains in src/.
Extended reasoning...
The PR changes one predicate in parse_attribute_selector (src/css/selectors/parser.rs) so a namespaced attribute selector with an operator is always boxed, and makes the boxed node's namespace a required field; it touches no security-sensitive surface. Inline findings already cover the @ namespace chunk-placement consequence and the test nits, so a human should weigh those; this note only records what else was examined.
Findings marked 🟡 are optional suggestions and need no follow-up push.
| attribute_flags.to_case_sensitivity(local_name_lower.v(), namespace.is_some()); | ||
| if namespace.is_some() && !local_name_is_ascii_lowercase { | ||
| // lightningcss boxes uppercase names (`|| !local_name_is_ascii_lowercase`) for its matcher. | ||
| if let Some(namespace) = namespace { |
Contributor
There was a problem hiding this comment.
🔴 Users who bundle several CSS files into one chunk can lose whole rules after merging that still applied on the base branch. Line 3520 now always keeps the xl|/*| prefix, but the linker neither hoists @ namespace ahead of earlier files' rules nor keeps it out of @ media/@ supports/@ layer wrappers (prepareCssAstsForChunk.rs:371, :424), so browsers ignore the declaration and drop every rule using the prefix, merged selector lists included. Fix: in the CSS linker, hoist each file's @ namespace rules to the chunk head and never wrap them in condition blocks, or at least emit a warning like esbuild's "@ namespace" rules are not supported so the drop is not silent.
Why this was flagged
A JS entry imports base.css (.icon{fill:red}) and then icons.css (@ namespace xl "urn:example:xlink"; a[href^="#"]{color:green} a[xl|href^="#"]{color:green}), or icons.css is reached through @ import url(icons.css) screen. prepareCssAstsForChunk.rs:369-378 strips only leading @ import/ignored rules and keeps @ layer statements; no code moves @ namespace, and wrap_rules_with_conditions (prepareCssAstsForChunk.rs:424, :497-547) nests the whole file, @ namespace included, inside @ layer/@ supports/@ media blocks. Browsers honour @ namespace only before every style rule and never inside a block, so the prefix xl is undeclared where the rules print. On the base branch both rules printed as a[href^="#"] and merged into one valid rule that applied. After src/css/selectors/parser.rs:3520 both print with the prefix; the minifier merges them into a[href^="#"],a[xl|href^="#"]{color:green} and the browser discards the entire rule as an invalid selector list, so the unprefixed a[href^="#"] styling that worked before is lost too. Nothing warns: no @ namespace handling exists under src/bundler/linker_context.
Verification: src/css/selectors/parser.rs:3518-3520 now does if let Some(namespace) = namespace { Ok(GenericComponent::AttributeOther(... so every operator attribute selector with a prefix keeps the prefix. src/bundler/linker_context/prepareCssAstsForChunk.rs:369-378 only strips Import/Ignored and retains LayerStatement; BundlerCssRule::Namespace is never hoisted.
Collaborator
Author
There was a problem hiding this comment.
Confirmed. This is the first Downsides bullet of the PR body. I checked it in Chrome 153 with a JS entry that imports base.css and then icons.css: main keeps 3 rules and this branch keeps 1.
This PR does not change the linker, for two reasons:
- The defect is the position of
@namespace, and it is on main today. In the same chunk main already dropsuse[xl|href]andxl|a. The parser of Bun rejects that chunk:@namespace rules must come before any other rules except @charset, @import, and @layer. - A move of the rule to the chunk head is not correct for every input. A default
@namespacechanges what the unprefixed type selectors of the other files match, and one prefix with two URLs in two files needs a rename. The first step is a warning, as esbuild has. That is a new diagnostic with its own tests.
The linker change is separate work in progress. The order of the two changes is a maintainer decision. If the silent drop is not acceptable in a release, the linker change can merge first, or both can ship together. The PR body now says this.
Collaborator
Author
There was a problem hiding this comment.
The linker change is now #46232 (draft).
- It prints each misplaced
@namespacerule once, after the@importrules of the chunk and outside each condition block. - It warns when one chunk cannot hold what the files declare. The cases: one prefix with two URLs, and a default namespace that the files with selectors do not share. It does not rename a prefix.
- I ran the two cases of this thread on that branch, which does not have the change of this PR. The JS entry prints
@namespace xl "urn:example:xlink";.icon{fill:red}and then the rules oficons.css. Thescreenimport prints@namespace xl "urn:example:xlink";.icon{fill:red}@media screen{...}. A secondbun buildof each output has no error and no warning.
#46232 is stacked on #46040, which is now on main. Proposed merge order: #46040, #46232, then this PR.
…se concurrently The ported `error_test` line was a skipped test with no body, so it checked nothing. Assert the parse error itself. The `bun pm diff` case spawns a process and shares no state, so it is `test.concurrent`.
Contributor
There was a problem hiding this comment.
Code review found no new issues
No new issues were found in this update; 1 finding from earlier reviews is still open above.
Still open from earlier reviews (1):
- 🔴
src/css/selectors/parser.rs:3520—Users who bundle several CSS files into one chunk can lose whole rules after merging that still applied on the base bra…
If you have decided not to act on one of these findings, resolve its thread (a reply alone leaves it open) and the next review stops counting it. To review this commit again now, use Re-run on its "Claude Code Review" check.
Jarred-Sumner
added a commit
that referenced
this pull request
Oct 27, 2026
### What does this PR do? Consolidates the open pull requests on the CSS parser (`src/css`: parsing, minifying, lowering, printing, CSS modules) into one. 179 open pull requests were in scope. Each was judged by one rule: **the output must mean to a browser what the input meant.** Every claim was run through a build of `main`, a build with the change, lightningcss 1.33 and Chromium 156 (CSSOM, computed values, painted pixels for colors and gradients), and counted against 10,116 real stylesheets: the published CSS of about 190 popular npm packages, plus stylesheets from open source repositories. 107 land here, whole or in part, most of them cut down. The source diff is net negative. Of the 10,116, 9,509 are stylesheets that someone ships. The rest are test fixtures of other tools (521), Tailwind v4 source that needs its plugin (59) and SCSS, PostCSS or template source (27). | 9,509 shipped stylesheets | `main` | this branch | |---|---|---| | fail to build | 71 | 35 | | ... of those, valid CSS that Bun rejects | | 0 | | minified output reads differently in Chromium than the input | 552 | 2 | | CSS modules with a name that is referenced but not defined, or exported but not defined | 166 | 0 | | all 10,116 | `main` | this branch | |---|---|---| | fail to build | 192 | 141 | | minified output reads differently in Chromium than the input | 593 | 15 | | build on `main`, fail here | | 0 | | right on `main`, wrong here (minified, and at the default targets) | | 0 | | size of the minified output, no targets | 162.32 MB | 162.47 MB (+0.093%) | | size of the output at the default targets | 224.1 MB | 210.2 MB (-6.2%) | A syntax error is a build error, with one exception: the IE star hack `*zoom: 1` is skipped, because tachyons and handsontable ship it. The 35 shipped stylesheets that fail are invalid CSS: 28 have a selector that Chromium drops (semantic-ui-css, swiper, @ionic/core, Adobe Spectrum, xp.css), 2 an `@import` after other rules, and one each `@supports not X and Y`, a nested `@keyframes`, a stray comma, a selector list in `::slotted()`, `@media screen\0` (govuk-frontend). The 2 that read differently fold a `color-mix()` inside a gradient (see the known gaps). The growth of the minified output is rules and declarations that `main` deleted by mistake: 87 KB of rules, 45 KB of prefixed declarations that only browser targets can rule out. #### Popular CSS that `main` breaks today - normalize.css, modern-normalize, sanitize.css: `font-family: monospace, monospace` is collapsed to `monospace`, which changes the font size from 16px to 13px (#46662). - CKEditor 5, Tabler, Carbon, VitePress, Ionic, PatternFly, Excalidraw: a rule of custom properties is deleted as a "duplicate" of a later rule with the same selector and other custom properties. 37 stylesheets lose 1,681 custom properties (#33684). - Material Components, daisyUI, DocSearch, plyr: a `var()` size loses to its own fallback (#42101). - nextra, daisyUI, CKEditor: declarations written after a nested rule are moved above it (#45462). - antd 4, purecss, govuk-frontend: browser hacks in selector lists start to apply everywhere (#42100). - foundation-sites, flatpickr, 98.css, blueprintjs, scalar, react-datepicker: the build fails on valid CSS (#46756, #38552, #38534). tachyons, handsontable: it fails on the IE star hack (#46751). - nodejs.org, Mantine: a CSS module exports classes that no rule defines, because the `@apply` or `@mixin` in them is moved out of the rule (#46759). - hint.css and 42 more: `z-index: 1000001` and `1000000` become the same number (#46715). - Adobe Spectrum: `--version: 5.0.1` prints as `5.1`. - A quarter of all stylesheets: minified output has a stray space in `align-items: center` (#41993). #### Behavior changes to look at first 1. **`light-dark()` is kept as written at the default browser targets** (#42009). The lowered form `var(--buncss-light, a) var(--buncss-dark, b)` is invalid unless a compiled `color-scheme` covers the element: 184 of the 215 real stylesheets that get it never define the variable, so every browser drops the declaration. The docs section on the polyfill is removed. 2. **`border` is not built from longhands** (#42072): `border-width:0;border-style:solid;border-color:red` stays three declarations, because `border` also resets `border-image`. 305 real stylesheets grow by 30 KB in total; `bootstrap.min.css` by 113 bytes, 5 gzipped. No real stylesheet was found where the old merge shows, so this is the one to drop if size matters more. 14 existing expectations change. 3. **A CSS module no longer exports names that only occur inside `:global(...)`** (#45487). 73 real modules lose 202 export keys, all of them names that no rule has. `import { g }` or `composes: g` of such a name becomes a build error. 4. **Container names and `@counter-style` names stay global in a CSS module** (#45247 by @mikamikasuki). `main` hashes the `@container` name but not `container-name`, so a named query never matches. postcss-modules (Vite, css-loader, Next.js) keeps them global; lightningcss and esbuild hash both. Global keeps a container that is queried from another file or from JS working. 5. **Syntax errors are build errors, also two that `main` lets through**: a media query that stops short (`@media screen and {`, `@media not {`, `@import "a.css" screen and;`) and `@media (width <) foo {`. No stylesheet of the 10,116 has either. A condition that is valid by the grammar though no browser knows it, `( ... )` or `fn( ... )`, is kept as written (#46756): `(min-width:0\0)`, `(not(hover))`. 6. **Declarations after a nested rule stay where they were written**, as a nested declarations rule (#45462). Changes the output of 199 real stylesheets; in a fuzz of 2,850 nested programs compared by computed style, `main` was wrong in 1,056 and the pull request's code, before it was trimmed here, in none. 7. **`Bun.color`**: `color()` inputs are converted instead of returned as a string (`Bun.color("color(srgb 1 0 0)", "hex")` was `"color(srgb 1 0 0)"`); `currentColor`, system colors and `light-dark()` give `null` in the converting formats instead of the keyword as a string; a relative color or `color-mix()` outside sRGB is clipped, not gamut-mapped (`hsl(from oklch(100% .399 336.3) h s l)` is `#ff5bff`, was `#fff`). 8. The `:-moz-any()` and `:-webkit-any()` copies of rules with `:is()` are gone at the default targets (#45945, #42029). The `:-webkit-any()` copy outranked the original rule: `.title{color:blue} :is(h1,h2,h3){color:red}` painted red. 5.8% of all default-target output was the `:-moz-any()` copies. 9. `Property` grows from 216 to 224 bytes: `Url` stores its text as a slice so that two `url()` values can be compared (#46895). The pull request packed a pointer and a `u32` behind `unsafe` to avoid that. #### Not in this PR, needs a decision - **Raise the default browser targets (#40369) and add a `cssTarget` option (#40368).** Today: Chrome 80, Edge 80, Firefox 78, Safari 14, Opera 67, and no public way to change them. At Vite 8's floor the output of the 9,924 stylesheets is 15.3% smaller (3.9% gzipped). About a dozen fixes here only matter at today's floor, and code for older targets is unreachable without the option. - Vendor prefixes for `user-select`, `appearance`, `hyphens` and five more (#45814): 1,116 real stylesheets lack a prefix they need at the default targets. And for `backdrop-filter` (#44648): 173. - Clip instead of gamut-map in the sRGB fallback of a plain wide-gamut color: deletes about 90 lines, changes every pinned fallback hex. If the mapping stays, #44647 by @oddharsh makes it closer to what browsers paint (colors off by 2/255 or more: 168 to 110 of 3,170 real ones). #### Changes **Rules: duplicates, merging, nesting, fallbacks** - The `:-moz-any()` copy of every rule with `:is()` or `:not(a, b)` is gone: Firefox 78 has `:is()` (#45945). 1,164 real stylesheets - Keep declarations written after a nested rule in place with a nested declarations rule (#45462). 379 real stylesheets - With nesting compiled away, an unknown at-rule inside a style rule was moved out of it: `.wrapper{@apply flex}` printed a bare `@apply flex;` and the rule was gone, so a CSS module exported a class that no rule defines. It now stays in a block under the compiled selector. 72 real modules with Tailwind's `@apply`, 25 with Mantine's `@mixin` (#46759). 316 real stylesheets - Keep !important in the rules generated for logical properties and color-scheme (#38597). 311 real stylesheets - With browser targets, remove an earlier duplicate rule only when its declaration block is equal (#46861). 171 real stylesheets - Compare custom property names in `PropertyId` equality and importance in duplicate-rule detection (#33684). 40 real stylesheets - Keep same-condition @supports rules and empty named @layer blocks (#46733). 31 real stylesheets - Keep target-added vendor prefix passes on cloned and re-minified rules, and never print a bare `:full-screen` (#43339). 12 real stylesheets - Keep the selectors on rules added for color fallbacks and logical properties (#43240). 3 real stylesheets - A later declaration of a property drops the `@supports` color copies of the earlier one, which printed after the rule and won (#45560). 2 real stylesheets - Do not merge style rules in a stylesheet that holds `revert-rule` (#46953). 1 real stylesheets - `@import ... supports(-webkit-mask: none)` kept its prefix (#38589) **Properties and shorthands** - Print align-items:center without a stray space when no safe/unsafe keyword is given (#41993). 3,317 real stylesheets - Emit the physical longhands instead of the inset shorthand for targets without it (#38583). 1,452 real stylesheets - Keep the stops of an upward gradient as written, and drop a `50%` hint only at the midpoint (#46790). 104 real stylesheets - Emit unparsed border-block-* declarations when compiling logical borders (#38582). 89 real stylesheets - Keep repeated font families and dedupe only the inserted system-ui fallbacks (#46662). 88 real stylesheets - A `width` / `height` / `min-*` / `max-*` with `var()` or `env()` was printed before the plain fallback written above it, so the fallback won (#42101). 26 real stylesheets - Keep box-orient and box-direction when flex-direction or flex-flow follows (#45672). 16 real stylesheets - Write held prefixed background declarations at every flush (#46882). 6 real stylesheets - Derive equality for Size2D and BorderRadius, and keep every prefix in the border-radius handler (#45665). 2 real stylesheets - Print `none` instead of an empty border-image, mask-border or mask-box-image value (#45143). 2 real stylesheets - Keep font/transition sub-properties on the side of the shorthand they were written on (#41990). 2 real stylesheets - CSS-wide keywords are not names: `font:12px Arial;font-family:inherit` printed `font:12px inherit`, `color-scheme:inherit` and `color-scheme:auto` printed `normal`, `transition-property:unset` was folded into `transition` (#42022). 2 real stylesheets - Only fold font longhands into `font` when the rule declared a `font` (#45459) - Keep a font family name quoted when its identifiers do not read back as the same name (#46606) - Stop rewriting valid positions into ones browsers reject (#45197) - `border` is no longer built from longhands unless the rule also sets what `border` resets (`border-image`), and an author's `border-image` reset is no longer dropped. `transition` is likewise only written where the rule wrote one, because it resets `transition-behavior` (#42072) - `border; border-image: <gradient>; border-image-slice: 1` lost the gradient in every default build (#42018) - A prefixed `linear-gradient` keeps its direction, written or generated: the prefixed syntax names the starting side and measures angles differently (#46697) **At-rules** - Print @font-face format() keywords as strings (#37979). 439 real stylesheets - Print @supports `not` conditions without a leading space (#38559). 88 real stylesheets - Reset after the number token of a unicode-range (#45835). 33 real stylesheets - Keep `<general-enclosed>` media and container conditions as written (#46756). 24 real stylesheets - A strict range such as `(width < 768px)` lowered for old targets still matched at exactly 768px. The step is now `.02px`. The `not all and` form for other units is not taken (#46806). 18 real stylesheets - Keep scanning an @supports condition after a nested block (#38552). 9 real stylesheets - Every `@counter-style name` printed as `@counter-stylename`, which browsers drop (also #46692). In a CSS module the name now stays global, like the `list-style` that refers to it (#33679). 9 real stylesheets - Keep a keyframe whose block has an invalid item (#46288). 2 real stylesheets - Read an @Property initial-value on the stylesheet's parser, keep an unmatched value as written (#45806). 2 real stylesheets - `@media {}` is `all`. A media query that stops after `and`, `or` or `not` (`@media screen and {`) is a build error; `main` printed `not all` or dropped the condition, silently. The `@layer` and type selector parts are not taken (#46869). 2 real stylesheets - Accept a name-only `@container` and a `style()` feature with no value (#46689). 1 real stylesheets - Parse `<timeline-range-name> <percentage>` keyframe selectors (#45652) - Allow `or` inside parentheses after a media type (#45088) - Print the `=` comparison in media and container queries as `=` (#45071) - Parse the @font-palette-values font-family descriptor as a list of family names (#45484) **Selectors** - Never wrap a selector list in :is() (#46787). 414 real stylesheets - Stop emitting :-webkit-any() copies of :is() that outrank the original rule (#42029). 373 real stylesheets - With browser targets, a selector list with a vendor-prefixed member was split, which revives hacks that rely on other engines dropping the whole list: `.s *::-ms-backdrop,.s{flex:auto}` applied everywhere. Rewritten; the list is printed as written (#42100). 42 real stylesheets - Print the vendor prefix on downleveled :any-link, :read-only, :read-write, :placeholder-shown and :autofill (#42131). 12 real stylesheets - Fix nesting lowering of a `&` that does not lead its selector (#43047). 8 real stylesheets - `@scope`: `&` and implicit selectors compile to `:where(:scope)`, relative selectors and bare declarations parse (#43165). 7 real stylesheets - Only reject bare :global / :local pseudo-classes in CSS modules (#38534). 5 real stylesheets - Stop truncating `@scope to (...)` and stop replacing `&` in the scope-end selector (#43146). 2 real stylesheets - `[xl|href$=".pdf"]` lost its namespace prefix (#45159). 2 real stylesheets - Match An+B keywords exactly and take only `+` as the leading sign (#42953). 1 real stylesheets - Parse ::details-content and ::picker() like ::part() (#45504). 1 real stylesheets - Parse :window-inactive as an ordinary pseudo-class, and accept it after ::selection (#45815) - Print :nth-col(1) and :nth-last-col(1) in functional form (#41575) - `li::before::marker` failed the build (#45810) - `&` inside `:nth-child(... of S)` is resolved when nesting is compiled away. The second selector serializer (326 lines) is deleted (#43024) **Colors and `Bun.color`** - Keep light-dark() as written under the default browser targets (#42009). 227 real stylesheets - Number and percentage channels parse in `lab()`, `lch()`, `oklab()`, `oklch()`, `hsl()` and `hwb()`; the hue of `lch` / `oklch` is no longer scaled by alpha (#45084). 130 real stylesheets - `Bun.color` returns `null` for `currentColor`, system colors and `light-dark()` in the converting formats, instead of the CSS keyword as a string (#33047). 130 real stylesheets - Relative colors: channel keywords are on the scale of their function (`rgb(from #369 calc(r + 10) g b)`), the origin's alpha is kept, a relative color kept as written gets no `@supports` copies, and a result outside sRGB is not folded (#45362). 31 real stylesheets - Keep rotate: 0deg out of none, and keep the origin alpha in relative colors (#38486). 13 real stylesheets - Compute the D50 reference white in f32 so greys convert to lab(l 0 0) like lightningcss (#38535). 7 real stylesheets - Return a missing hue for a grey from conversions into lch, oklch, hsl and hwb (#45201). 5 real stylesheets - Fix color(a98-rgb), srgb-linear relative colors and color-mix(in xyz-d50) (#38487). 4 real stylesheets - Match named colors without regard to ASCII case (#45092). 3 real stylesheets - Fold min(), max() and clamp() over plain numbers (#39515) - `calc(l - .08)` in a percentage channel of a relative color became NaN and printed `#000` (also #45970) (#45971) - Bun.color: convert color() inputs instead of returning them as a CSS string (#38488) - A `color-mix(in srgb, ...)` result outside sRGB prints `color(srgb ...)` instead of a gamut-mapped hex (#39269) **`calc()` and numbers** - Rounding to 6 significant digits ate into the integer part: `z-index:2147483647` became `2147480000`, `max-width:9999999px` became `10000000px`, `--x:1234567.5` became `1234570`. It now only cuts a fraction short: a value kept as tokens prints its source text, a typed value prints every integer digit and at least one digit of the fraction (#46715). 43 real stylesheets - A number without a unit is no longer repaired into `px` (`height:1.5715` is dropped by a standards-mode browser, so it prints as written), `calc(-1 * 0)` is not a length, and on a property of the range [0,∞] (sizes, border radii, padding, border and outline widths, gap, `flex-basis`, `font-size`) a `calc()` that folds below zero prints `0` instead of an invalid negative literal, and a negative literal no longer replaces the valid declaration before it (`width:10px;width:-5px` printed `width:-5px`) (#42104). 24 real stylesheets - Print numbers from the f32's shortest digits, not its f64 expansion (#38565). 17 real stylesheets - Print negative numbers below 1 with a single minus sign (#38516) - Keep math functions over two different length units as written (#38489) - Fold rem() with a truncated quotient, so it keeps the sign of the dividend (#32286) - A one-argument `min()` / `max()` around a sum printed without any function (`width:100% - 20px`) (#46145) - `round()` breaks ties upward and handles a negative step as browsers do (#45249) **CSS modules** - A CSS module exports its `@keyframes` names (`styles.spin`). Hashing is unchanged (#46720). 145 real stylesheets - A name inside `:global(...)` prints plain but was exported as `name_<hash>`, a class no rule has (also #38573) (#45487). 90 real stylesheets - Keep container names global in CSS modules (#45247). 6 real stylesheets - Tag the keyframes name when an `animation` value falls back to raw tokens (#46034). 6 real stylesheets - In a plain stylesheet `composes: a from "./b.css"` was treated as an import: the file was inlined and an absolute path printed (#45961). 4 real stylesheets - Drop a rejected composes instead of failing the file at print time (#38538). 1 real stylesheets - Keep every rule's custom properties for the composes conflict check (#38523) - Keep composes working after a nested rule in the same block (#38520) - `IdentOrRef::hash` read 2 of 16 bytes, so in release builds every class of a module hashed alike (#30784) **Tokens, `url()`, diagnostics** - The block skip stack no longer allocates on every block exit (#39533) - Report the diagnostic's line without its line breaks in position.lineText (#38342). 192 real stylesheets - Compare `url()` values by their text (#46895). 26 real stylesheets - Values kept as tokens keep the blanks they were written with instead of having them re-invented at print time: `attr(x type(<number>))` printed `type(< number> )`, which browsers drop. Minified output still drops the blanks that cannot matter (#45577). 19 real stylesheets - The IE star hack (`*zoom:1`) failed the whole build. The declaration is skipped, as every browser does. It is the one syntax error that builds: tachyons, handsontable and jasmine ship it (#46751). 8 real stylesheets - The path of a copied asset spliced into `url()` is always quoted, so a file name with a space or a parenthesis cannot end the `url()` (#41557). 7 real stylesheets - Move the skip loop of parse_until_before out of the generic body (#39520) - Remove dead code from bun_css: the unused `impl Default for Property` (#45618) - Default the at-rule and qualified-rule parser traits, drop the url_to_css shim (#31999) **Speed** Four inputs that took quadratic or exponential time, or produced output out of proportion, are now linear, with no new limit and no extra pass (#31639, #42243, #38531, #43421). **Tests only** - `css-fuzz.test.ts` never ran in CI and timed out on debug builds; it is a deterministic table now (#38500) - `nth-anplusb-ident.test.ts` counts heaps in a child process (#46331) - `color.test.ts` checks the ansi-16 sweep with one `expect()` (#42824) - Not CSS, but it failed this PR's CI and fails on `main` too: `ws-proxy.test.ts` on Windows, "a message sent during a TLS renegotiation arrives after it". The helper server now renegotiates from the callback of the frame's write (#46170) **No pull request covered these** - `--v: 5.0.1` printed as `5.1`, `--w: 1.0.0` as `10`, `--x: 1+2` as `12`, `2n+1` as `2n1`: a number token that touches another keeps its source text. - `color-scheme: auto` printed as `normal`, and `color-scheme: dark light` as `light dark`. - A bare `:global` or `:local` in a CSS module sets the scope of the names after it, up to the end of the selector, as in css-loader. It was a build error. - The scrollbar states (`a:horizontal`, `::-webkit-scrollbar{&:horizontal{}}`) are valid in a plain compound, as in WebKit and Blink. - Without browser targets, `-webkit-box-align`, `-ms-flex-align` and the like were dropped next to their standard form (flatpickr, foundation-sites, materialize-css: 28 stylesheets), and `-webkit-fill-available` before `-moz-available` (beercss). - `(-o-min-device-pixel-ratio: 2/1)` printed as `2`. - `sin()`, `cos()` and `tan()` are exact at multiples of 90deg: `calc(100px * cos(90deg))` printed `-.00000437114px`. - A `display-p3` color at targets that have P3 but not the other `color()` spaces (Safari 10.1 to 14) got itself as a fallback. - `width: rem(-18px, 5px)` folds to a negative literal once `rem()` is right; it prints `0`. - Consecutive nested declarations rules, which arise when same-query `@media` blocks in one rule merge, are folded into one and count against the existing selector expansion limit as the `&{}` rules they replace did. #### Known and not fixed here - Four longhands are still folded into a `transition` the author did not write where the targets add a prefixed copy of a property (`mask-image` at Chrome 80): only the shorthand gives the copy its own times. - A later `background`, `box-shadow` or `border-*` declaration still loses to the `@supports` copy of an earlier `var()` value of the same property with a wide-gamut color. Same on `main`; #45560 is taken for the properties of the fallback handler and for unparsed values only. - A merged rule prints the unprefixed name in the passes of the rule it absorbed: `.d::-webkit-input-placeholder{}.d::-moz-placeholder{}` prints `::placeholder` for the second (#42106, not taken: it breaks the merge of prefix-equivalent rules). - The `border`, `outline` and `font` shorthands, `line-height`, `scroll-padding`, `background-size` and a few more still print a `calc()` that folds below zero as a negative literal. No real stylesheet has one. - `all` is not a property Bun knows, so `a{margin-top:1px;all:unset}` prints `all` first. Same on `main`. - A selector kept as raw tokens loses the blank before `*` when minified: `--sel: .dark *` prints `.dark*`. Same on `main`. - `width:calc(0% + 12px)` folds to `12px`, which lays out differently in a table cell. Same on `main`. - The `:dir()` / `:lang()` rules of a lowered logical property print before the nested rules of their rule, so a logical declaration written after a nested rule of equal specificity still loses to it. Same on `main`. - A fraction is still rounded to 6 significant digits (`12345.678` prints `12345.7`, `33.3333333333%` prints `33.3333%`). Keeping every digit would add up to 282 KB over the corpus. - `@keyframes "quoted"` is hashed in a module but not exported. - In a module, a keyframes name inside a `var()` fallback is not hashed: `animation: var(--enter, fade 1s)`. Same on `main`. - A `color-mix()` or relative color folded to a hex inside a gradient changes the interpolation from Oklab to sRGB (VS Code, clawhub). Printing `color(srgb ..)` instead needs a fallback for `mask-image`, `list-style-image` and custom properties at the default targets, which have none. - A comma list in `@container` still fails the build. - After a bare `:global`, names that are hashed at print time (`::view-transition-old(foo)`) are still hashed; inside `:global(...)` they are not. #### Pull requests in scope that do not land here - Duplicates of a pull request that lands here: #36961 (of #37979), #38478 (of #46662), #38480 (of #46733), #38482 (of #46715), #38491 (of #38500), #38508 (of #45201), #38513 (of #45362), #38573 (of #45487), #38640 (of #38500), #45525 (of #45247), #45589 (of #46756), #45970 (of #45971) - Already fixed on `main`: #38674 - Right, but for input nobody writes (0 of 10,116 stylesheets, and not new syntax): #31916, #38526, #38592, #39349, #41139, #41801, #42042, #42484, #43078, #45604, #45908, #46086, #46221, #46224, #46273, #46694, #46707, #46737, #46755, #46816, #46870, #46934 - Right or harmless, but not worth their code, their bigger output or the behavior they change: #30905, #31924, #33332, #34426, #36225, #38006, #38512, #38547, #38551, #38561, #38572, #38576, #38607, #38623, #38667, #38692, #42106, #42912, #42918, #43407, #43434, #44700, #45442, #45546, #45747, #45759, #45825, #45946, #46061, #46127, #46206 - Need a decision (see above), stay open: #40368, #40369, #44647, #44648, #45814 - Stays open: #45787 Out of scope: CSS linking and chunking in the bundler, the dev server, docs-only pull requests, and repository-wide sweeps that touch `src/css` in passing. Thanks to @mikamikasuki (#45247), @alii (#39520, #31999) and @oddharsh, whose measurements on #40369 and #41990 were used. Fixes #16727. Fixes #24770. Fixes #30772. Fixes #44704. Fixes #45089. Fixes #45237. Fixes #46872. ### How did you verify your code works? - The 35 CSS test files pass on a debug build, also with `FORCE_COLOR=1`. 600+ of the tests in this branch fail on a build of `main`. An earlier head of this branch passed all 179 CI jobs that ran. - The reproduction of each issue listed above was run on `main` (wrong) and on this branch (right). - Differential run over the 10,116 stylesheets, `main` against this branch, minified without targets and through `Bun.build` at the default targets: no stylesheet that builds on `main` fails; Chromium 156 compares the output with the input rule by rule (CSSOM, then computed values on a sized element in a standards-mode document, colors as painted pixels in sRGB and P3). The comparison has 195 control pairs that must read equal or different. For stylesheets that read differently on both builds, mostly because of lowering, the sets of differences were compared; the three new ones are two minifier fixtures that are wrong on both and one comparison artifact. - CSS modules are checked for consistency instead, since hashed names defeat the comparison: every reference points at a name the output defines, every export exists. - `Bun.color`: 59 inputs in 13 formats on both builds; every changed cell was read.
Collaborator
Collaborator
Author
|
Verified on main at 7942008 with a debug build.
Nothing more is needed from this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
bun builddrops the namespace prefix of an attribute selector with an operator and a lowercase name:[xl|href$=".pdf"]prints as[href$=".pdf"], a different selector.[xl|href="a"]{color:red}[href="a"]{color:blue}prints only[href="a"]{color:#00f}.namespace.is_some() && !local_name_is_ascii_lowercaseinparse_attribute_selector(src/css/selectors/parser.rs:3532). Only that arm keeps the namespace.Fix
[ns|name]already does.Option.test/js/bun/css/css.test.ts(99 new tests fail without the fix),test/bundler/esbuild/css.test.ts,test/bundler/css/css-modules.test.ts. Self-reviewed: 22 concerns raised, 21 addressed. Rejected: a@namespacewarning, a separate linker change.Background
[xl|href]matcheshrefin the namespace that@namespace xldeclares (xlink:hrefin SVG).[href]matches only no namespace.AttributeOther, a Box, has a namespace field.||of lightningcss. It also boxes names with an uppercase letter, for a matcher Bun does not have: a 104-byte Box and 2 minified bytes for[viewBox="abc"].Downsides
@namespacewhere browsers ignore it. They then drop each rule that uses the prefix, selector list included. Main printed a valid unprefixed selector there (Notes).[name op value]selectors: 1 more conditional branch, 8 fewer instructions, byte-identical output on 15 fixture sheets.Notes
Where this came from. A comparison of
bun buildoutput with esbuild and lightningcss found it. No GitHub issue reports it. The&&came with the CSS parser port (#14122) and is in every release since bun-v1.1.30. lightningcssselectors/parser.rs:2587has||in that place.Question for a maintainer. The predicate differs from lightningcss and servo on purpose. Is that acceptable, or do you want
||for token parity? With||, a name with an uppercase letter and no namespace costs one 104-byte Box per parse and per deep clone, and prints 2 more bytes under--minify. The second commit and the five pin tests ([Foo=bar],[viewBox=abc],[tYPE=a],[xl|Href="x"],[y=z]) would change with it. The first commit does not depend on the answer.Repro
Main d1cb7db and 1.4.3-canary print
[href$=".pdf"],[href^="http"],use[href="#i"],a[xl|href]. This PR prints all four with their prefix, the same bytes as lightningcss-cli 1.0.0-alpha.72. esbuild 0.28.2 also keeps the prefixes, and it warns"@namespace" rules are not supported [unsupported-@namespace]. The prefix was lost for all six operators, with theiandsflags, and wherever an attribute selector can be written (nesting,@scope,:not,:is,:where,:has,:host,::slotted,::cue,:nth-child(.. of ..)). CSS modules printed.a[xl|href="x"]as.a_HASH[href="x"].The first downside in detail
Browsers honour
@namespaceonly before every style rule.bun buildprints it in the body of the file that declares it. So it is ignored in three cases:base.cssand thenicons.css).@importof a file that prints rules.media,supports()orlayer(). The@namespaceis then inside that block.A selector with a prefix that is not declared is not valid, so the browser drops the whole rule. That includes the other selectors of its list, written by the author or merged by Bun from rules with equal declarations. Checked in Chrome 153 with
base.cssthenicons.css(.icon{fill:red},use[xl|href^="#icon-"]{fill:red},a[href^="#"], a[xl|href^="#"]{color:green}): main keeps 3 rules, this PR keeps 1. On main the same chunk already dropsuse[xl|href]andxl|a. The parser of Bun rejects that chunk too:@namespace rules must come before any other rules except @charset, @import, and @layer. This PR does not change where@namespaceis printed. That needs a change in the CSS linker (src/bundler/linker_context/prepareCssAstsForChunk.rs): a warning as in esbuild, or a correct move of the rule. The order of the two changes is a maintainer decision. If the silent drop in those chunks is not acceptable in a release, merge the linker change first or ship both together.Measurements (main d1cb7db against this PR, same machine and toolchain)
[data-a=v]0 / 0,[viewBox=v]0 / 0,[xl|href=v]0 / 1,000,[xl|Href=v]1,000 / 1,000. 15 fixture sheets 0 / 0.arena_lowercasecalls on the fixtures 7,654 / 7,654. (gdb breakpoint hit counts, debug builds.):not([xl|href=v], .b)with the default targets: 0 on main (it builds no boxed node), 1,000 on the PR.:not([xl|Href=v], .b)gives 1,000 on the PR.parse_selector, callees stepped over (gdbnexti, release builds, two identical runs each), PR against main:[href=v]534 / 66 / 20 against 517 / 59 / 21.[hreF=v]552 / 65 / 23 against 551 / 63 / 24.[xl|href=v]548 / 62 / 21 against 520 / 59 / 21.[xl|hreF=v]577 / 65 / 24 against 571 / 63 / 25.AttributeFlags::to_case_sensitivityintoparse_selector, so the line above counts that function on the PR and not on main. With its instructions added on main (gdbstepi):[href=v]542 / 65 on main, 534 / 66 on PR.[hreF=v]565 / 65, 552 / 65.[xl|href=v]530 / 60, 548 / 62.[xl|hreF=v]581 / 64, 577 / 65.stepi, six runs of[href=v]): main 3,998 to 4,009 and PR 3,998 to 4,001, with one run of each on a shorter allocator path (2,434 and 2,426).bun buildoutput, main against PR: the 15 fixture sheets and a sheet of uppercase names are identical (sha256), 2,732,962 bytes minified and 3,155,382 plain. The 1,000-rule files for[data-a=v],[viewBox=v]and[xl|Href=v]are identical.[xl|href=v]rules grow by 3 bytes each plain and 5 each with--minify.parse_selector::<Selectors>20,775 to 21,971 bytes (nm -S).to_case_sensitivity(1,114 bytes on main) is no longer a separate function..textofbun105,051,807 to 105,051,551 bytes, 256 fewer (size).size_of::<Component>()48 to 48 bytes. Boxed attribute node 104 to 96 bytes (gdb on debug builds).[xl|href=v]rules and for 1,000:not([xl|href=v], .b)rules. 0 on main for 1,000[xl|Href=v]rules.Tests
[|att=val]pass on both builds by design. They fail if the predicate becomes||.describe("namespace")is a port of lightningcsstest_namespace, whichcss.test.tsdid not have. Its error case asserts the message for an@namespaceafter a style rule.bun pm diffprints parsed CSS with no minify pass and compares the two prints. One test covers that path:use[xl|href="#i"]againstuse[href="#i"]was"formattingOnly": trueand is nowfalse.css.test.ts(1,403 pass),esbuild/css.test.ts(58 pass),css-modules.test.ts(15 pass),attr-selector-namespace-star.test.ts,doesnt_crash.test.ts.nested-selector-expansion.test.tsandnested-vendor-prefix-duplication.test.tspass with a longer timeout. They exceed 5 s on a debug build.Not in this PR
@namespacein a chunk (above)..a { &svg|use[xl|href="#i"] {} }lowers to.asvg|use[xl|href="#i"]. The prefix is kept, but the type selector is not first. css: fix nesting lowering of a&that does not lead its selector #43047 is open for that lowering.::slotted(.a)::first-lineparses. lightningcss rejects it (InvalidState). The check after::slotted()inparse_one_simple_selectorreturnsOkin both arms.attr(xl|href)prints asattr(xl| href)without--minify. That is the token list printer, not the selector parser.local_name_lowerkeeps only the tail of the name from the first uppercase letter, so[tYPE=a]looks upypein the HTML case-insensitive attribute table. That table spellshttp_equivandaccept_charsetwith underscores. No release entry point can observe either.--minify, the boxed node and:nth-child(2n of [href="y"])keep the quotes on a value. esbuild prints 2 bytes fewer. Minified[Foo=bar]differs from lightningcss, which prints[Foo="bar"].bun pm diffstill decides "formatting only" from the equality of two prints. This PR removes one wrong case of that.[attr]copies its name to lowercase for a matcher Bun does not have: 896 arena allocations on the 15 fixture sheets.&inside :nth-child(... of S), :host(), ::slotted() and ::cue() #43024, css: keep incompatible selectors that fail the same way in one rule #40464.[human-review] gate passed · iteration 0 · 4 files touched
fails on main (without fix)
passes on PR (with fix)
diff hotspot
gate history · 1 passed · 0 rejected · iteration 0
evidence per changed file