list: show symlink targets (for tar and zip)

[tommady]

close: #932

[marcospb19]

Hey sorry for the eager review but what if is_dir and symlink_target get collapsed into one field for an enum for file type.

Regular and Directory unit variants
Symlink tuple variant with PathBuf inside.

so you express in the type system that symlink_target can't be some while is_dir is true.

wdyt

[tommady]

Hey sorry for the eager review but what if is_dir and symlink_target get collapsed into one field for an enum for file type.

Regular and Directory unit variants Symlink tuple variant with PathBuf inside.

so you express in the type system that symlink_target can't be some while is_dir is true.

wdyt

No worries at all,
I appreciate the suggestion!

I agree this is a great idea.
Collapsing is_dir and symlink_target into a single enum would model the state much more clearly and lets the type system enforce that a symlink target can’t exist while the entry is a directory.

[tommady]

Hey @marcospb19,

I added support for hard links in the tar archive as well. This goes slightly beyond the scope of the original issue, so feel free to let me know if you’d prefer to keep the change more minimal.

For now, I made hard links display the same way as symlinks because I wasn’t sure what the best visual distinction would be (I’m definitely not a UI/UX designer 🤪).

Whenever you have time, I’d appreciate a review.

Thanks!

[marcospb19]

Wait I accidentally pushed something directly to main 🤦, let me solve this conflict.

[marcospb19]

lgtm!

[marcospb19]

Yay thanks

For the changelog I'll later figure out an automation later so you don't have to do this manually xD.

Merging