Skip to content

check_rom(): 'if (ds_addr[0] != 0)' is always true #5

Description

@ramereth
if (ds_addr[0] != 0) {

ds_addr[0] is an array, so this decays to a pointer and is always non-null.
The else branch — which would assign the fallback MAC ...:00:01:25 — is dead
code.

Low impact on its own, but it hides the intended fallback path and interacts
with the factory-reset-on-boot bug.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions