Skip to content

refactor: create PopupMenu with themedContext#2029

Merged
WhiredPlanck merged 1 commit into
osfans:developfrom
WhiredPlanck:popupmenu
Jun 28, 2026
Merged

refactor: create PopupMenu with themedContext#2029
WhiredPlanck merged 1 commit into
osfans:developfrom
WhiredPlanck:popupmenu

Conversation

@WhiredPlanck

@WhiredPlanck WhiredPlanck commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

Pull request

Issue tracker

Fixes will automatically close the related issues

Fixes # N/A

Feature

Describe features of this pull request

Fix the issue that the PopupMenu triggered on a candidate doesn't adapt to Dark Mode.

Code of conduct

Code style

Build pass

  • make debug

Manually test

  • Done

Code Review

  1. No wildcards import
  2. Manual build and test pass
  3. GitHub Action CI pass
  4. At least one contributor review and approve
  5. Merged clean without conflicts
  6. PR will be merged by rebase upstream base

Daily build

Login and download artifact at https://github.com/osfans/trime/actions

Additional Info

@WhiredPlanck WhiredPlanck requested a review from Copilot June 20, 2026 08:57

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread app/src/main/java/com/osfans/trime/ime/core/BaseInputView.kt
@WhiredPlanck WhiredPlanck merged commit 2f0ce55 into osfans:develop Jun 28, 2026
4 checks passed
@WhiredPlanck WhiredPlanck deleted the popupmenu branch June 28, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants