[GR-74768] Fix elementWantedForTraceback frame descriptor check.#736
Closed
graalvmbot wants to merge 1 commit intomasterfrom
Closed
[GR-74768] Fix elementWantedForTraceback frame descriptor check.#736graalvmbot wants to merge 1 commit intomasterfrom
graalvmbot wants to merge 1 commit intomasterfrom
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GR-73555 changes the frame descriptor for a ContinuationRootNode to not match the root node, which breaks an assumption made by elementWantedForTraceback.
I originally tried to migrate this method (and getLineno) to use Bytecode DSL-recommended APIs like BytecodeFrame/BytecodeLocation, but
TruffleStackTraceElementlocations do not always belong to the same root as the frame. Until GR-62198 is addressed we're stuck with this workaround.