Repository navigation
feat(readline): drop configure-project-installer, inline build with self-extract + patches - #65
Merged
Merged
Conversation
…elf-extract + patches Switch fromsource:readline to its own inline autotools build, applying the cluster-A sandbox-fix template and self-managing the source extraction + patch pipeline: * paths derived from pkginfo.install_file() * sandbox-blocked APIs replaced: path.absolute, os.cd, os.files glob * re-extract source from tarball at install-hook start (xlings doesn't re-extract on retry, so any partial-patch state from a previous failed run was leaking through and tripping `Hunk FAILED at 1` on the patchlevel hunk) * patch fetch + apply + configure + make + install chained in single sh -c * patches mirror switched ftpmirror.gnu.org → ftp.gnu.org (the round- robin mirror occasionally 404s on individual patches between rotations; canonical source is stable) * CPPFLAGS now also points at <sysroot>/usr/include/ncurses so readline configure finds termcap.h (ncurses installs it under the ncurses/ subdir; readline's `#include <termcap.h>` won't otherwise match, and the build fails with stub `extern int tputs ();` decls vs real 3-arg call sites in display.c) * license: GPL → SPDX GPL-3.0 * shell-cp glob replaces os.files(*.pc) loops in config()/uninstall() Verified end-to-end in xlings 0.4.9 iso (with cluster-B leaf 3 ncurses MERGED upstream as #64): ✓ source self-extract + 13 upstream readline-8.2 patches applied ✓ termcap.h detected, tputs/tgoto resolve to real 3-arg signatures ✓ produced libreadline.so.8.2 + libhistory.so.8.2 + soname symlinks ✓ pkgconfig files copied to subos sysroot/usr/lib/pkgconfig ✓ "10 package(s) installed" exit 0 Cluster B leaf 4/8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fromsource:readlinefromxim:configure-project-installershim to its own inline buildHunk FAILED at 1on the patchlevel hunk)ftpmirror.gnu.org→ftp.gnu.org(mirror occasionally 404s on individual patches between rotations)CPPFLAGSextended with<sysroot>/usr/include/ncursesso readline's#include <termcap.h>resolves (ncurses installstermcap.hunder thencurses/subdir)GPL-3.0Verification (local isolated xlings 0.4.9, with cluster-B 3 ncurses #64 already merged)
checking for termcap.h... yes,tputs/tgotoresolve to real 3-arg signatureslibreadline.so.8.2+libhistory.so.8.2+ soname symlinksTest plan