file: fix concurrent load/commit race condition - #24
Closed
JerryM-Quectel wants to merge 1 commit into
Closed
Conversation
Root cause With blocking LOCK_SH, a reader could open an old inode first, then wait for the writer lock; after the writer renamed and unlocked, the reader still operated on that stale inode, causing stale reads or lost updates under contention. Solution Changed the read path to use non-blocking shared lock attempts and, on lock contention, close and reopen the file before retrying so it tracks the latest inode behind the path. Signed-off-by: jerry.meng <jerry.meng@quectel.com>
Author
|
Close this PR, will resubmit via dedicated feature branch with proper Signed-off-by. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
With blocking LOCK_SH, a reader could open an old inode first, then wait for the writer lock; after the writer renamed and unlocked, the reader still operated on that stale inode, causing stale reads or lost updates under contention.
Solution
Changed the read path to use non-blocking shared lock attempts and, on lock contention, close and reopen the file before retrying so it tracks the latest inode behind the path.