luci-app-mwan3: add resolveDefault to rule.js - #8979
Open
ckorber wants to merge 1 commit into
Open
Conversation
openwrt-ai
reviewed
Aug 25, 2026
openwrt-ai
left a comment
openwrt-ai
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed 1 new commit. The commit message matches its diff, but the change itself looks like a no-op — see the inline comment on the ACL entry.
Generated by Claude Code
ckorber
marked this pull request as draft
August 25, 2026 18:08
Hardening the call for cases if the command is unavailable. Signed-off-by: Christian Korber <ckorber@tdt.de>
ckorber
force-pushed
the
pr/mwan3_acl_error
branch
from
August 25, 2026 19:27
66b465c to
e381d3b
Compare
ckorber
marked this pull request as ready for review
August 25, 2026 19:27
openwrt-ai
reviewed
Aug 26, 2026
openwrt-ai
left a comment
openwrt-ai
left a comment
Collaborator
There was a problem hiding this comment.
Re-reviewed after the force-push. The ACL change from the previous head is gone and replaced with the L.resolveDefault() hardening — the new commit message matches its diff, so no commit-check findings. CI is green on e381d3b. Two inline notes: the underlying denial still appears unexplained (the in-tree ACL grant looks correct), and the PR title/body are stale relative to what the diff now does.
Generated by Claude Code
ckorber
marked this pull request as draft
August 26, 2026 05:22
ckorber
changed the title
ckorber
marked this pull request as ready for review
August 26, 2026 09:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request details
Description
rule.js reports an error stating that access to command is denied. This is caused by the call to
fs.exec_directfor/usr/libexec/luci-mwan3 ipset dumpin the load function. Dump does not write names on my setup leading to the error.Thus, hardening the call for cases, when the result is empty, is reasonable.
Screenshot or video of changes (if applicable)
Before
After
Maintainer (preferred)
@systemcrash @feckert
Tested on
OpenWrt version: openwrt-25.12
LuCI version: luci openwrt-25.12
Web browser(s): firefox