luci-app-lldpd: remove broken CSS version suffix - #8967
Conversation
openwrt-ai
left a comment
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit.
Confirmed the premise: SubstituteVersion in luci.mk only walks *.htm and *.ut files and only matches the <%# … PKG_VERSION %> / {# … PKG_VERSION #} forms, so a literal #PKG_VERSION inside a .js view was never substituted. luci-app-lldpd/Makefile sets no PKG_VERSION either, and these two lines were the only PKG_VERSION occurrences in any JS/template file in the tree. Removing the suffix is correct.
One formatting nit inline.
Generated by Claude Code
The stylesheet link ends with '?v=#PKG_VERSION'. Nothing in this repository replaces that placeholder, so it does nothing. Remove it and link the stylesheet directly, like other applications do. Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
429bd8a to
d713bbe
Compare
openwrt-ai
left a comment
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit; no new issues found.
The force-push applied the previous formatting nit to both config.js:64 and status.js:71 — both now read as a single line, matching the rest of the tree. Commit subject scope and body still match the diff, and CI is green on d713bbe (eslint, build, CodeQL, FormalityCheck).
Generated by Claude Code
The stylesheet link ends with
?v=#PKG_VERSION, a placeholder from the original Tano Systems build system that nothing in this repository replaces. Remove it and link the stylesheet directly, like other applications do.