Fix broken and potentially paralyzing parallelism MAKEFLAGS#14
Open
daniel-santos wants to merge 1 commit intoopenwrt:chaos_calmerfrom
Open
Fix broken and potentially paralyzing parallelism MAKEFLAGS#14daniel-santos wants to merge 1 commit intoopenwrt:chaos_calmerfrom
daniel-santos wants to merge 1 commit intoopenwrt:chaos_calmerfrom
Conversation
Really, any build system should use the makeflags passed to it. The exception is when such a system makes more than one sub-package like OpenWRT. In this case, we now have --load-average to over-loading CPU, cache and memory, but this probably did not exist when OpenWRT's parallelism was added. But as-is it isn't just broken, it's horrific. I stepped away and came back to a five minute load average of 139 when I only have 4 CPU cores! The OOM killer saved me. This patch adds an alternative feature, enabling the user to explicitly specify per-package makeflags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Really, any build system should use the makeflags passed to it. The
exception is when such a system makes more than one sub-package like
OpenWRT. In this case, we now have --load-average to prevent over-loading
CPU, cache and memory, but this probably did not exist when OpenWRT's
parallelism was added.
As-is it isn't just broken, it's horrific. I stepped away and came
back to a five minute load average of 139 when I only have 4 CPU cores!
The OOM killer saved me. This patch adds an alternative feature,
enabling the user to explicitly specify per-package makeflags.