Skip to content

Allow nanosecond precision in NeTEx date times - #7983

Merged
leonardehrenfried merged 1 commit into
opentripplanner:dev-2.xfrom
leonardehrenfried:netex-java-model-update
Sep 8, 2026
Merged

leonardehrenfried merged 1 commit into
opentripplanner:dev-2.xfrom
leonardehrenfried:netex-java-model-update

Conversation

@leonardehrenfried

Copy link
Copy Markdown
Member

Summary

In #7956 we noticed that NeTEx date times with sub-millisecond precision would silently be converted to null, which would fail the parsing of an Italian NeTEx feed with data like this:

<UicOperatingPeriod
	xmlns="http://www.netex.org.uk/netex"
	xmlns:ns2="http://www.opengis.net/gml/3.2"
	xmlns:ns3="http://www.siri.org.uk/siri" version="153" id="IT:ITH4:UicOperatingPeriod:U182_20260416_0">
	<FromDate>2026-05-03T23:30:09.398629+02:00</FromDate>
	<ToDate>2026-08-31T00:00:00</ToDate>
	<ValidDayBits>111111011111101111110111111010111101111100111110011111001111100111110011111001111100111110011111001111100111110011111001</ValidDayBits>
</UicOperatingPeriod>

entur/netex-java-model#298 in the upstream library fixes the issue.

BTW, I'm not saying that this is good data - it is very ambiguous, but that is a separate issue.

Issue

noi-techpark/opendatahub-mentor-otp#330

@leonardehrenfried leonardehrenfried added this to the 2.10 (next release) milestone Sep 8, 2026
@leonardehrenfried
leonardehrenfried requested a review from a team as a code owner September 8, 2026 07:31
@leonardehrenfried leonardehrenfried added the !Bug Apply to issues describing a bug and PRs witch fixes it. label Sep 8, 2026
@codecov

codecov Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.59%. Comparing base (02c0b4b) to head (252358b).
⚠️ Report is 16 commits behind head on dev-2.x.

Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #7983   +/-   ##
==========================================
  Coverage      74.58%   74.59%           
- Complexity     22615    22618    +3     
==========================================
  Files           2503     2503           
  Lines          87668    87668           
  Branches        8665     8665           
==========================================
+ Hits           65389    65392    +3     
+ Misses         19240    19239    -1     
+ Partials        3039     3037    -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@leonardehrenfried
leonardehrenfried added this pull request to the merge queue Sep 8, 2026
Merged via the queue into opentripplanner:dev-2.x with commit dd979c5 Sep 8, 2026
8 checks passed
@leonardehrenfried
leonardehrenfried deleted the netex-java-model-update branch September 8, 2026 14:27
t2gran pushed a commit that referenced this pull request Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!Bug Apply to issues describing a bug and PRs witch fixes it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants