chore(tests): failing repros for the #1031 review findings (DSPX-4703)

[pflynn-virtru]

What

Red-phase-only test branch for the defects found reviewing #1031. Nothing is fixed here — cd lib && npm test is expected to fail, and that is the deliverable. Draft, because it is not mergeable until the fixes land.

Every new describe ships controls that pass, so each failure is attributable to the defect rather than to the harness.

Why

Each finding gets a test that fails now and passes once the defect is fixed, so the fixes can be reviewed against evidence instead of argument. Three findings from the review are deliberately not here — see the bottom.

Failures

16 under mocha, 17 under karma, plus 1 type-level.

Test	Defect
4.2.2 files with HS256 segments → round-trips	segmentIntegrityVersion422 HMACs a lossy UTF-8 round-trip of the ciphertext; the reader HMACs raw bytes. Writes archives nothing can open. Newly reachable since #1030 made segmentIntegrityAlgorithm settable.
decrypt error propagation → several segments fail	Only the first failed chunk is awaited; the rest reject into the void. The caller catches the IntegrityError and Node still tears the process down.
a CryptoService whose hmac returns a pooled view → 4.2.2	Writer hex-encodes sig.buffer, reader hex-encodes the view. A Node CryptoService returning a pooled Buffer writes files that fail their own read and leak heap into the manifest.
manifest validation (×3)	Missing segments, missing rootSignature, non-base64 hash → bare TypeError / InvalidCharacterError, not TdfError. All land before asRootIntegrityAlgorithm can fail closed.
read path ordering → rejected without a rewrap	A GMAC-rooted file costs a full KAS rewrap — policy decision, audit record, DEK release — before it is refused.
read path ordering → assertions before root signature	Attacker-supplied JWT headers, which name their own verification key via jwk/x5c, are parsed while the manifest is still unauthenticated.
root algorithm rejection taxonomy (×2)	HS384/HS512 are reported as tampering rather than unsupported. Contradicts root-signature.spec.ts → "rejects an unknown root algorithm rather than defaulting to HS256", which is the point: both cannot hold, and this branch says that assertion is the wrong one.
streamToBuffer rejects non-Uint8Array chunks (×3)	Returns an empty or all-zero buffer reported as success. Response threw.
{type: "stream"} sources → decrypt accepts what fromSource does	decrypt no longer takes a Blob source; fromSource still does.
{type: "stream"} sources → fromSource propagates the original error	Karma only. seekable.ts still drains through Response, so OpenTDF.open()/read() launders an IntegrityError into TypeError: Failed to fetch — the exact masking #1031 removed from the legacy surface. Passes under mocha; Node has nothing to mask.
root-signature.spec.ts → forged GMAC signature control	The legacy fixture emits base64(raw); a 4.2.2 reader compares base64(hex(...)) — 24 chars vs 44. The "rejects a GMAC root downgrade" test passes on unfixed code, so it pins nothing.
root-signature.spec.ts → reverseSegments is a permutation	Silently drops bytes on a payload that is not an exact multiple of the segment size (negative start reads from the end). Safe only because the fixture is exactly 4×1024.
npm run test:types	alg: RootIntegrityAlgorithm | string collapses to string, so the invariant tdf.ts documents ("cannot even be typed as GMAC") does not hold on the one field an attacker controls.

Infrastructure notes

• lib/tests/types/ holds deliberate type-level failures. It is excluded from the build's tsconfig and checked by a new npm run test:types, chained after test:with-server — otherwise a compile error would abort the build and hide all 16 runtime failures.
• New specs share lib/tests/mocha/helpers/tdf-fixtures.ts rather than adding a third copy of the scaffolding root-signature.spec.ts and integrity-algorithms.spec.ts each carry. Folding those two in is left alone.
• eslint.config.mjs names the extra tsconfig so the parser can place tests/types.

Not covered

Three review findings have no determinate failing test, and guessing at one would pin a requirement nobody has chosen:

• Lowercase segmentHashAlg is now accepted by the reader. Whether to re-tighten or to correct the now-false comment at integrity-algorithms.spec.ts:156 is a decision, not a defect.
• Round-trip tests assert on the live in-memory manifest. Latent fragility; passes today for incidental reasons.
• Duplication cleanup (fourth copy of the concat helper, four spellings of the same algorithm guard, deprecated IntegrityAlgorithm still re-exported).

How to test

cd lib && npm test

What CI actually shows. npm test chains its stages with &&, so the mocha failure stops the run there:

npm run build && npm run test:with-server && npm run test:types
  test:with-server -> npm run test:mocha && npm run test:wtr && npm run test:browser && ...

CI therefore reports 424 passing / 16 failing from mocha and nothing further. The karma-only failure (fromSource masking, finding 11) and the three TS2578 type errors (finding 6) are real and reproduce locally, but are unreachable in CI until the mocha failures are fixed — at which point they surface on their own, one stage at a time.

To see them now, run the stages individually:

cd lib && npm run build
node dist/web/tests/server.js &
npx mocha 'dist/web/tests/mocha/**/*.spec.js'   # 424 passing, 16 failing
npm run test:browser                            # 423 passing, 17 failing
npm run test:types                              # 3x TS2578

The workflow itself cannot be adjusted from this branch: build-and-test.yaml calls reusable_build-and-test.yaml@main, so CI always runs main's copy.

🤖 Generated with Claude Code

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}