fix(sdk): use deterministic BaseTDF IVs (DSPX-4496) - #1018
Draft
dmihalcik-virtru wants to merge 2 commits into
Draft
fix(sdk): use deterministic BaseTDF IVs (DSPX-4496)#1018dmihalcik-virtru wants to merge 2 commits into
dmihalcik-virtru wants to merge 2 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
count-iv
Signed-off-by: Dave Mihalcik <dmihalcik@virtru.com>
dmihalcik-virtru
force-pushed
the
DSPX-4496-count-iv
branch
from
September 8, 2026 22:17
1a022c6 to
9302e8e
Compare
dmihalcik-virtru
changed the base branch from
main
to
DSPX-4591-zip64-conformance
September 8, 2026 22:17
|
dmihalcik-virtru
added this pull request to stack #1033
September 10, 2026 20:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Random per-segment IVs accumulate collision risk at high segment counts. Deterministic per-TDF invocation values guarantee that payload segments do not repeat an IV under their freshly generated payload key.
Verification
cd lib && npm testcd lib && npm run lintThe integration test inspects the emitted ZIP payload and verifies segment IVs 1, 2, and 3. Unit tests cover metadata IV 0, counter carry, invalid ranges, and the 2^32 ceiling.
Crypto risk
This construction requires a fresh payload key per TDF, as the normal SDK path already provides. Reusing a custom payload key across TDFs would repeat the IV sequence and is unsafe.