Skip to content

Add Octavia SKMO playbooks for amphora and network setup - #3965

Merged
openshift-merge-bot[bot] merged 2 commits into
openstack-k8s-operators:mainfrom
vakwetu:add-octavia-amphora-wait-skmo
Jul 28, 2026
Merged

Add Octavia SKMO playbooks for amphora and network setup#3965
openshift-merge-bot[bot] merged 2 commits into
openstack-k8s-operators:mainfrom
vakwetu:add-octavia-amphora-wait-skmo

Conversation

@vakwetu

@vakwetu vakwetu commented May 26, 2026

Copy link
Copy Markdown
Contributor

Add SKMO OVN Octavia Tempest support for leaf region
Add EDPM recreate hook and extend network-values templates for Octavia
NAD generation. Leaf-region Tempest config lives in ci-framework-jobs
05-tests.yaml; reproducer uses post_tests: [] like the uni job.

Depends-On: openstack-k8s-operators/architecture#759

Signed-off-by: Ade Lee alee@redhat.com
Assisted-by: Claude Opus 4.6

@evallesp

Copy link
Copy Markdown
Contributor

First commit already reviewed in #3956
Do we want to close that MR? I'd rather go removing that commit from this MR.

@evallesp evallesp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM

Comment thread hooks/playbooks/skmo/configure-octavia-network.yaml Outdated
Comment thread hooks/playbooks/skmo/configure-octavia-network.yaml Outdated
Comment thread hooks/playbooks/skmo/configure-octavia-network.yaml Outdated
@evallesp

Copy link
Copy Markdown
Contributor

First commit already reviewed in #3956 Do we want to close that MR? I'd rather go removing that commit from this MR.

it was merged.

@vakwetu
vakwetu force-pushed the add-octavia-amphora-wait-skmo branch from e1bc8e2 to e1304ee Compare May 28, 2026 19:51
@vakwetu

vakwetu commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

removed merged commit.

Comment thread hooks/playbooks/skmo/configure-octavia-network.yaml Outdated
@vakwetu
vakwetu force-pushed the add-octavia-amphora-wait-skmo branch from e1304ee to 9c05293 Compare June 8, 2026 22:13
@vakwetu
vakwetu force-pushed the add-octavia-amphora-wait-skmo branch from 9c05293 to f1da49a Compare June 9, 2026 02:07
@vakwetu
vakwetu force-pushed the add-octavia-amphora-wait-skmo branch from f1da49a to 8c6b432 Compare June 12, 2026 20:17
@vakwetu
vakwetu force-pushed the add-octavia-amphora-wait-skmo branch from 8c6b432 to c75c2f1 Compare June 12, 2026 20:22
@Deydra71
Deydra71 requested review from evallesp and gthiemonge June 15, 2026 05:46
@Deydra71
Deydra71 force-pushed the add-octavia-amphora-wait-skmo branch from c75c2f1 to dc7396d Compare June 17, 2026 10:28
@Deydra71

Copy link
Copy Markdown

Rebased so test project can run with the latest changes

Comment thread .pre-commit-config.yaml
@Deydra71
Deydra71 force-pushed the add-octavia-amphora-wait-skmo branch from 1105b42 to 13e493d Compare July 10, 2026 08:12
@Deydra71
Deydra71 requested a review from rebtoor July 16, 2026 11:39
@vakwetu
vakwetu force-pushed the add-octavia-amphora-wait-skmo branch from 13e493d to a41a0b6 Compare July 20, 2026 10:21
@vakwetu

vakwetu commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

@rebtoor @danpawlik -hey - jobs have passed - this looks good to merge!

evallesp
evallesp previously approved these changes Jul 21, 2026

@evallesp evallesp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

danpawlik
danpawlik previously approved these changes Jul 21, 2026
Comment thread roles/federation/tasks/run_keycloak_setup.yml Outdated
vakwetu added 2 commits July 27, 2026 06:46
…y issues

Add Octavia network-values fixes, federation ordering, SKMO EDPM stale
deployment hooks, and va-multi-skmo reproducer updates.

Signed-off-by: Ade Lee <alee@redhat.com>
Assisted-by: Claude Opus 4.6
Skip wait/approve when the RHSSO operator CSV is already Succeeded and
only approve unapproved install plans when a fresh install is needed.

Signed-off-by: Ade Lee <alee@redhat.com>
Assisted-by: Claude Opus 4.6
@Deydra71
Deydra71 dismissed stale reviews from danpawlik and evallesp via ded56cd July 27, 2026 04:54
@Deydra71
Deydra71 force-pushed the add-octavia-amphora-wait-skmo branch from a41a0b6 to ded56cd Compare July 27, 2026 04:54
@openshift-ci openshift-ci Bot removed the lgtm label Jul 27, 2026
@rebtoor

rebtoor commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

/approve
/lgtm

@openshift-ci

openshift-ci Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rebtoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 7b03878 into openstack-k8s-operators:main Jul 28, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants