enable hibernation for 4.18-4.22 rhoe cluster pools - #84045
Conversation
Signed-off-by: Adam D. Cornett <adc@redhat.com>
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acornett21 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
💤 Files with no reviewable changes (6)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe changes remove ChangesClusterPool sizing configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The change allows the specified idle cluster pools to hibernate instead of running continuously; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. Full details: Stable And Deterministic Test NamesExplanation PASS. The pull request changes only six ClusterPool YAML files. The diff removes Full details: Test Structure And QualityExplanation PASS: The pull request changes only six ClusterPool YAML manifests. The exact diff removes Full details: Microshift Test CompatibilityExplanation PASS: The pull request changes only six ClusterPool YAML files. The diff removes existing Full details: Single Node Openshift (Sno) Test CompatibilityExplanation PASS: The pull request changes only six ClusterPool YAML manifests. The diff removes Full details: Topology-Aware Scheduling CompatibilityExplanation PASS — The pull request changes only six Full details: Ote Binary Stdout ContractExplanation PASS: The pull request changes only six ClusterPool YAML files. The exact diff removes Full details: Ipv6 And Disconnected Network Test CompatibilityExplanation PASS — The pull request changes only six ClusterPool YAML files. The verified HEAD^..HEAD diff removes Full details: No-Weak-CryptoExplanation PASS: The complete pull-request commit changes only six ClusterPool YAML files and removes six Full details: Container-PrivilegesExplanation PASS. The pull request changes only six ClusterPool YAML files and deletes Full details: No-Sensitive-Data-In-LogsExplanation PASS: The commit changes only six ClusterPool YAML files. Each change deletes one ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@acornett21: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Removes
runningCountfrom the rhoe-owned SNO cluster pools (4.18, 4.19, 4.20, 4.21, 4.22) so clusters hibernate when unclaimed instead of running 24/7. Real claim-usage data (Prow/GCS job history) shows these pools sit idle82–99%+of the time depending on version, and observed hibernation resume times are typically ~3 minutes (worst case observed: a fresh reinstall of35–55 minif resume exceeds the 20mresumeTimeout, still within the 1h claim timeout). Estimated savings: ~$3,642/month in EC2 compute.Summary by CodeRabbit
runningCountfrom six ClusterPool manifests while preserving each pool's configuredsize.