Skip to content

OPRUN-4717: Add Prow config for operator-framework/library-olm - #84034

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
tmshort:oprun-4717-library-olm-prow-config
Aug 26, 2026
Merged

OPRUN-4717: Add Prow config for operator-framework/library-olm#84034
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
tmshort:oprun-4717-library-olm-prow-config

Conversation

@tmshort

@tmshort tmshort commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Description

Adds tide, approve, and lgtm Prow plugin configuration for the new
operator-framework/library-olm repository, mirroring the existing
operator-framework/operator-controller setup.

This is part of the repository bootstrap for the OLMv0→OLMv1 migration
library prototype (OPRUN-4717 / OCPSTRAT-2693).

Changes

core-services/prow/02_config/operator-framework/library-olm/

File Purpose
_prowconfig.yaml Tide config: squash merge on main, requires approved+lgtm, blocks on do-not-merge/* and jira/invalid-bug labels
_pluginconfig.yaml Enables /approve (require_self_approval) and /lgtm (review_acts_as_lgtm) commands
OWNERS Approvers and reviewers matching the library-olm root OWNERS file

Relation to existing config

Modeled directly on the operator-framework/operator-controller config in
core-services/prow/02_config/operator-framework/operator-controller/.
The only difference is the repo name.

Jira

OPRUN-4717 — Phase 1 repo bootstrap

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Adds Prow configuration for operator-framework/library-olm.
  • Enables Tide squash merges on main when pull requests have approved and lgtm, unless blocking labels are present.
  • Configures /approve and /lgtm commands with repository-specific approval rules.
  • Adds approvers and reviewers from the repository’s OWNERS configuration.

Adds tide, approve, and lgtm plugin configuration for the new
operator-framework/library-olm repository, mirroring the existing
operator-framework/operator-controller setup:

- Tide: squash merge on main, requires approved+lgtm, blocks on
  do-not-merge/* and jira/invalid-bug labels
- Plugins: /approve (require_self_approval) and /lgtm
  (review_acts_as_lgtm)
- OWNERS: same approvers/reviewers as operator-controller

Part of the library-olm Phase 1 repo bootstrap (OPRUN-4717).

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort tmshort changed the title Add Prow config for operator-framework/library-olm (OPRUN-4717) OPRUN-4717: Add Prow config for operator-framework/library-olm Aug 25, 2026
@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 6f919af4-0d78-4f00-95ed-7f579e2a3950

📥 Commits

Reviewing files that changed from the base of the PR and between cbad96f and 3f2f6c4.

📒 Files selected for processing (3)
  • core-services/prow/02_config/operator-framework/library-olm/OWNERS
  • core-services/prow/02_config/operator-framework/library-olm/_pluginconfig.yaml
  • core-services/prow/02_config/operator-framework/library-olm/_prowconfig.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The pull request adds Prow ownership, approval, LGTM, and Tide configuration for operator-framework/library-olm. Tide targets the main branch and permits squash merges when required labels are present and blocking labels are absent.

Changes

library-olm Prow integration

Layer / File(s) Summary
Ownership and approval plugins
core-services/prow/02_config/operator-framework/library-olm/OWNERS, core-services/prow/02_config/operator-framework/library-olm/_pluginconfig.yaml
Defines approvers and reviewers. Enables the approve and lgtm behavior with repository-specific settings.
Tide merge policy
core-services/prow/02_config/operator-framework/library-olm/_prowconfig.yaml
Configures Tide for main with required approval labels, blocking labels, repository targeting, and squash merges.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 3f2f6

This PR adds localized Prow configuration for the new repository, with no actionable merge-blocking risk remaining beyond normal checks and review.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS — The pull request adds only three YAML/OWNERS configuration files. The committed diff contains no test source files and no Ginkgo test declarations or titles. Therefore, it introduces no unstabl…
Test Structure And Quality ✅ Passed PASS: The pull request adds only three YAML/OWNERS files under the Prow configuration directory. The committed diff contains no Ginkgo test files or test constructs such as It, BeforeEach, AfterEach, …
Microshift Test Compatibility ✅ Passed PASS — The pull request adds only three Prow YAML/OWNERS files. The commit diff contains no Go files, test files, or Ginkgo declarations such as It, Describe, Context, or When. It therefore introduces…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The pull request adds only three Prow YAML/OWNERS configuration files. The exact diff contains no new Ginkgo e2e tests or test constructs such as It(), Describe(), Context(), or When(). Therefor…
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The pull request adds only Prow configuration and an OWNERS file. The verified commit changes no deployment manifests, operator code, controllers, or scheduling fields such as affinity, topology…
Ote Binary Stdout Contract ✅ Passed PASS. The pull request adds only three configuration files: OWNERS, _pluginconfig.yaml, and _prowconfig.yaml. The exact commit diff contains no Go source, test suite setup, main(), or process-…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The pull request adds only three YAML/OWNERS configuration files. The exact commit diff contains no Ginkgo test declarations, test files, IPv4 literals, network parsing, or test connectivity cod…
No-Weak-Crypto ✅ Passed PASS: The pull request only adds OWNERS and Prow YAML configuration. The exact patch contains no MD5, SHA1, DES, 3DES, RC4, Blowfish, or ECB usage, custom cryptography, or secret/token comparisons.
Container-Privileges ✅ Passed PASS. The pull request adds only an OWNERS file and two Prow YAML configuration files. The diff contains no container or Kubernetes manifest and no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN…
No-Sensitive-Data-In-Logs ✅ Passed PASS: The pull request adds only Prow YAML configuration and an OWNERS file. The exact diff contains no logging statements, log templates, credentials, tokens, passwords, API keys, or customer data. T…
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding Prow configuration for the operator-framework/library-olm repository.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)

Full details: Stable And Deterministic Test Names

Explanation

PASS — The pull request adds only three YAML/OWNERS configuration files. The committed diff contains no test source files and no Ginkgo test declarations or titles. Therefore, it introduces no unstable or overly specific test names.

Full details: Test Structure And Quality

Explanation

PASS: The pull request adds only three YAML/OWNERS files under the Prow configuration directory. The committed diff contains no Ginkgo test files or test constructs such as It, BeforeEach, AfterEach, Eventually, Consistently, or Expect. Therefore, the stated test-structure requirements are not applicable.

Full details: Microshift Test Compatibility

Explanation

PASS — The pull request adds only three Prow YAML/OWNERS files. The commit diff contains no Go files, test files, or Ginkgo declarations such as It, Describe, Context, or When. It therefore introduces no MicroShift-incompatible e2e test to assess.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

PASS: The pull request adds only three Prow YAML/OWNERS configuration files. The exact diff contains no new Ginkgo e2e tests or test constructs such as It(), Describe(), Context(), or When(). Therefore, the SNO compatibility check is not applicable.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS: The pull request adds only Prow configuration and an OWNERS file. The verified commit changes no deployment manifests, operator code, controllers, or scheduling fields such as affinity, topology spread, node selectors, tolerations, replicas, or PDBs. The topology-aware scheduling check is therefore not applicable.

Full details: Ote Binary Stdout Contract

Explanation

PASS. The pull request adds only three configuration files: OWNERS, _pluginconfig.yaml, and _prowconfig.yaml. The exact commit diff contains no Go source, test suite setup, main(), or process-level logging and stdout writes. Therefore, the OTE binary stdout contract does not apply to these changes.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS: The pull request adds only three YAML/OWNERS configuration files. The exact commit diff contains no Ginkgo test declarations, test files, IPv4 literals, network parsing, or test connectivity code. The URLs present are configuration/documentation links, not external connections made by an e2e test.

Full details: Container-Privileges

Explanation

PASS. The pull request adds only an OWNERS file and two Prow YAML configuration files. The diff contains no container or Kubernetes manifest and no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root execution setting. The word root appears only in the OWNERS source comment.

Full details: No-Sensitive-Data-In-Logs

Explanation

PASS: The pull request adds only Prow YAML configuration and an OWNERS file. The exact diff contains no logging statements, log templates, credentials, tokens, passwords, API keys, or customer data. The listed public repository usernames and documentation URLs do not create sensitive-data logging.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 25, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

@tmshort: This pull request references OPRUN-4717 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Description

Adds tide, approve, and lgtm Prow plugin configuration for the new
operator-framework/library-olm repository, mirroring the existing
operator-framework/operator-controller setup.

This is part of the repository bootstrap for the OLMv0→OLMv1 migration
library prototype (OPRUN-4717 / OCPSTRAT-2693).

Changes

core-services/prow/02_config/operator-framework/library-olm/

File Purpose
_prowconfig.yaml Tide config: squash merge on main, requires approved+lgtm, blocks on do-not-merge/* and jira/invalid-bug labels
_pluginconfig.yaml Enables /approve (require_self_approval) and /lgtm (review_acts_as_lgtm) commands
OWNERS Approvers and reviewers matching the library-olm root OWNERS file

Relation to existing config

Modeled directly on the operator-framework/operator-controller config in
core-services/prow/02_config/operator-framework/operator-controller/.
The only difference is the repo name.

Jira

OPRUN-4717 — Phase 1 repo bootstrap

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from Prucek and smg247 August 25, 2026 18:42
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 25, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@tmshort: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-ci

openshift-ci Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

@tmshort: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pedjak pedjak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2026
@openshift-ci

openshift-ci Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pedjak, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 41e02e8 into openshift:main Aug 26, 2026
12 checks passed
@openshift-ci

openshift-ci Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

@tmshort: Updated the following 2 configmaps:

  • config configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-operator-framework-library-olm-_prowconfig.yaml using file core-services/prow/02_config/operator-framework/library-olm/_prowconfig.yaml
  • config configmap in namespace ci at cluster core-ci using the following files:
    • key core-services-prow-02_config-operator-framework-library-olm-_prowconfig.yaml using file core-services/prow/02_config/operator-framework/library-olm/_prowconfig.yaml
Details

In response to this:

Description

Adds tide, approve, and lgtm Prow plugin configuration for the new
operator-framework/library-olm repository, mirroring the existing
operator-framework/operator-controller setup.

This is part of the repository bootstrap for the OLMv0→OLMv1 migration
library prototype (OPRUN-4717 / OCPSTRAT-2693).

Changes

core-services/prow/02_config/operator-framework/library-olm/

File Purpose
_prowconfig.yaml Tide config: squash merge on main, requires approved+lgtm, blocks on do-not-merge/* and jira/invalid-bug labels
_pluginconfig.yaml Enables /approve (require_self_approval) and /lgtm (review_acts_as_lgtm) commands
OWNERS Approvers and reviewers matching the library-olm root OWNERS file

Relation to existing config

Modeled directly on the operator-framework/operator-controller config in
core-services/prow/02_config/operator-framework/operator-controller/.
The only difference is the repo name.

Jira

OPRUN-4717 — Phase 1 repo bootstrap

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Adds Prow configuration for operator-framework/library-olm.
  • Enables Tide squash merges on main when pull requests have approved and lgtm, unless blocking labels are present.
  • Configures /approve and /lgtm commands with repository-specific approval rules.
  • Adds approvers and reviewers from the repository’s OWNERS configuration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tmshort
tmshort deleted the oprun-4717-library-olm-prow-config branch August 26, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants