OPRUN-4717: Add Prow config for operator-framework/library-olm - #84034
Conversation
Adds tide, approve, and lgtm plugin configuration for the new operator-framework/library-olm repository, mirroring the existing operator-framework/operator-controller setup: - Tide: squash merge on main, requires approved+lgtm, blocks on do-not-merge/* and jira/invalid-bug labels - Plugins: /approve (require_self_approval) and /lgtm (review_acts_as_lgtm) - OWNERS: same approvers/reviewers as operator-controller Part of the library-olm Phase 1 repo bootstrap (OPRUN-4717). Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Todd Short <tshort@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe pull request adds Prow ownership, approval, LGTM, and Tide configuration for Changeslibrary-olm Prow integration
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This PR adds localized Prow configuration for the new repository, with no actionable merge-blocking risk remaining beyond normal checks and review. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.) Full details: Stable And Deterministic Test NamesExplanation PASS — The pull request adds only three YAML/OWNERS configuration files. The committed diff contains no test source files and no Ginkgo test declarations or titles. Therefore, it introduces no unstable or overly specific test names. Full details: Test Structure And QualityExplanation PASS: The pull request adds only three YAML/OWNERS files under the Prow configuration directory. The committed diff contains no Ginkgo test files or test constructs such as It, BeforeEach, AfterEach, Eventually, Consistently, or Expect. Therefore, the stated test-structure requirements are not applicable. Full details: Microshift Test CompatibilityExplanation PASS — The pull request adds only three Prow YAML/OWNERS files. The commit diff contains no Go files, test files, or Ginkgo declarations such as It, Describe, Context, or When. It therefore introduces no MicroShift-incompatible e2e test to assess. Full details: Single Node Openshift (Sno) Test CompatibilityExplanation PASS: The pull request adds only three Prow YAML/OWNERS configuration files. The exact diff contains no new Ginkgo e2e tests or test constructs such as It(), Describe(), Context(), or When(). Therefore, the SNO compatibility check is not applicable. Full details: Topology-Aware Scheduling CompatibilityExplanation PASS: The pull request adds only Prow configuration and an OWNERS file. The verified commit changes no deployment manifests, operator code, controllers, or scheduling fields such as affinity, topology spread, node selectors, tolerations, replicas, or PDBs. The topology-aware scheduling check is therefore not applicable. Full details: Ote Binary Stdout ContractExplanation PASS. The pull request adds only three configuration files: Full details: Ipv6 And Disconnected Network Test CompatibilityExplanation PASS: The pull request adds only three YAML/OWNERS configuration files. The exact commit diff contains no Ginkgo test declarations, test files, IPv4 literals, network parsing, or test connectivity code. The URLs present are configuration/documentation links, not external connections made by an e2e test. Full details: Container-PrivilegesExplanation PASS. The pull request adds only an OWNERS file and two Prow YAML configuration files. The diff contains no container or Kubernetes manifest and no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root execution setting. The word Full details: No-Sensitive-Data-In-LogsExplanation PASS: The pull request adds only Prow YAML configuration and an OWNERS file. The exact diff contains no logging statements, log templates, credentials, tokens, passwords, API keys, or customer data. The listed public repository usernames and documentation URLs do not create sensitive-data logging. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@tmshort: This pull request references OPRUN-4717 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( |
|
@tmshort: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pedjak, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@tmshort: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
Adds tide, approve, and lgtm Prow plugin configuration for the new
operator-framework/library-olmrepository, mirroring the existingoperator-framework/operator-controllersetup.This is part of the repository bootstrap for the OLMv0→OLMv1 migration
library prototype (OPRUN-4717 / OCPSTRAT-2693).
Changes
core-services/prow/02_config/operator-framework/library-olm/_prowconfig.yamlmain, requiresapproved+lgtm, blocks ondo-not-merge/*andjira/invalid-buglabels_pluginconfig.yaml/approve(require_self_approval) and/lgtm(review_acts_as_lgtm) commandsOWNERSRelation to existing config
Modeled directly on the
operator-framework/operator-controllerconfig incore-services/prow/02_config/operator-framework/operator-controller/.The only difference is the repo name.
Jira
OPRUN-4717 — Phase 1 repo bootstrap
🤖 Generated with Claude Code
Summary by CodeRabbit
operator-framework/library-olm.mainwhen pull requests haveapprovedandlgtm, unless blocking labels are present./approveand/lgtmcommands with repository-specific approval rules.OWNERSconfiguration.