CNTRLPLANE-3516: Use self-managed Azure kubeconfig for deprovisioner

[bryan-cox]

Update the Azure deprovisioner to read the root cluster kubeconfig from /etc/hypershift-ci-jobs-self-managed-azure/kubeconfig.

Remove the obsolete azure-hypershift-ci credential mount because the self-managed Azure credential bundle now provides the kubeconfig.

JIRA: https://redhat.atlassian.net/browse/CNTRLPLANE-3516

Always review AI generated responses prior to use.
Generated with Claude Code via openshift-developer plugin

Summary by CodeRabbit

• Updates the OpenShift CI HyperShift Azure deprovisioner to use the self-managed Azure root cluster kubeconfig at /etc/hypershift-ci-jobs-self-managed-azure/kubeconfig.
• Removes the obsolete azure-hypershift-ci credential mount.
• The change aligns deprovisioning with the self-managed Azure credential bundle.

[openshift-ci-robot]

@bryan-cox: This pull request references CNTRLPLANE-3516 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Update the Azure deprovisioner to read the root cluster kubeconfig from /etc/hypershift-ci-jobs-self-managed-azure/kubeconfig.

Remove the obsolete azure-hypershift-ci credential mount because the self-managed Azure credential bundle now provides the kubeconfig.

JIRA: https://redhat.atlassian.net/browse/CNTRLPLANE-3516

Always review AI generated responses prior to use.
Generated with Claude Code via openshift-developer plugin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: dc3c8d72-e740-40d3-9553-782d2666c8c2

📥 Commits

Reviewing files that changed from the base of the PR and between cbad96f and 4572556.

📒 Files selected for processing (2)

• ci-operator/step-registry/hypershift/azure/deprovision/hypershift-azure-deprovision-commands.sh
• ci-operator/step-registry/hypershift/azure/deprovision/hypershift-azure-deprovision-ref.yaml

💤 Files with no reviewable changes (1)

• ci-operator/step-registry/hypershift/azure/deprovision/hypershift-azure-deprovision-ref.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review.

---

Walkthrough

The Azure deprovision step now uses the self-managed Azure CI kubeconfig. The step no longer mounts the previous Azure HyperShift kubeconfig credential.

Changes

Azure deprovision configuration

Layer / File(s)	Summary
Use the self-managed Azure kubeconfig ci-operator/step-registry/hypershift/azure/deprovision/hypershift-azure-deprovision-commands.sh, ci-operator/step-registry/hypershift/azure/deprovision/hypershift-azure-deprovision-ref.yaml	The command sets KUBECONFIG to /etc/hypershift-ci-jobs-self-managed-azure/kubeconfig. The step removes the previous Azure HyperShift kubeconfig credential mount.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 45725

This PR switches Azure deprovisioning to the self-managed kubeconfig and removes the obsolete credential mount. No actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: updating the deprovisioner to use the self-managed Azure kubeconfig.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS: The pull request changes only a shell kubeconfig path and YAML credential mounts. The exact diff contains no Ginkgo test declarations or test titles, and no dynamic test information. The stable …
Test Structure And Quality	✅ Passed	PASS: The pull request changes only a shell command file and its step reference YAML. The diff contains no Ginkgo test file, It block, or test-related setup, cleanup, wait, or assertion. The custom …
Microshift Test Compatibility	✅ Passed	PASS: The pull request changes only a shell command file and a step reference YAML file. The diff adds no Ginkgo e2e tests or test declarations, so the MicroShift test compatibility check is not appli…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The pull request changes only the Azure deprovisioner shell script and its YAML reference. The committed diff adds no Ginkgo tests or test declarations such as It(), Describe(), Context(), or Wh…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The commit changes only a CI deprovision shell script and its credential reference. It changes KUBECONFIG and removes an obsolete credential mount. It adds no deployment, operator, or controll…
Ote Binary Stdout Contract	✅ Passed	PASS — The check is not applicable. The pull request changes only a CI shell step and its YAML reference. The diff changes KUBECONFIG and removes an obsolete credential mount. It does not modify an …
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS. The pull request changes only one shell script and one step YAML file. It adds no Ginkgo e2e tests or test code. The only added line sets KUBECONFIG to the self-managed Azure bundle path, so the…
No-Weak-Crypto	✅ Passed	PASS: The committed diff only changes the KUBECONFIG path and removes an obsolete credential mount. It introduces no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB usage, custom cryptography, or secret/toke…
Container-Privileges	✅ Passed	PASS. The exact diff changes only the KUBECONFIG path and removes an obsolete credential mount. It adds no privileged, host namespace, SYS_ADMIN, allowPrivilegeEscalation, or root security setti…
No-Sensitive-Data-In-Logs	✅ Passed	PASS. The pull request adds only a KUBECONFIG path and removes a credential mount. It adds no logging statements and does not log passwords, tokens, API keys, or kubeconfig contents. Existing logs for…

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

Full details: Stable And Deterministic Test Names

Explanation

PASS: The pull request changes only a shell kubeconfig path and YAML credential mounts. The exact diff contains no Ginkgo test declarations or test titles, and no dynamic test information. The stable test-name check is therefore not applicable.

Full details: Test Structure And Quality

Explanation

PASS: The pull request changes only a shell command file and its step reference YAML. The diff contains no Ginkgo test file, It block, or test-related setup, cleanup, wait, or assertion. The custom check is therefore not applicable.

Full details: Microshift Test Compatibility

Explanation

PASS: The pull request changes only a shell command file and a step reference YAML file. The diff adds no Ginkgo e2e tests or test declarations, so the MicroShift test compatibility check is not applicable.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

PASS: The pull request changes only the Azure deprovisioner shell script and its YAML reference. The committed diff adds no Ginkgo tests or test declarations such as It(), Describe(), Context(), or When(). Therefore, the SNO test compatibility check is not applicable.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS: The commit changes only a CI deprovision shell script and its credential reference. It changes KUBECONFIG and removes an obsolete credential mount. It adds no deployment, operator, or controller scheduling constraints, and the patch contains no affinity, topology spread, replica, node selector, taint, or PDB changes.

Full details: Ote Binary Stdout Contract

Explanation

PASS — The check is not applicable. The pull request changes only a CI shell step and its YAML reference. The diff changes KUBECONFIG and removes an obsolete credential mount. It does not modify an OpenShift Tests Extension binary or its process-level Go setup. The shell script's existing echo calls therefore do not violate the OTE binary stdout contract.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS. The pull request changes only one shell script and one step YAML file. It adds no Ginkgo e2e tests or test code. The only added line sets KUBECONFIG to the self-managed Azure bundle path, so the IPv4 and external-connectivity conditions do not apply.

Full details: No-Weak-Crypto

Explanation

PASS: The committed diff only changes the KUBECONFIG path and removes an obsolete credential mount. It introduces no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB usage, custom cryptography, or secret/token comparisons. The existing SHA256 comment is unchanged and is not a flagged algorithm.

Full details: Container-Privileges

Explanation

PASS. The exact diff changes only the KUBECONFIG path and removes an obsolete credential mount. It adds no privileged, host namespace, SYS_ADMIN, allowPrivilegeEscalation, or root security setting. The current and parent manifests contain none of the checked privilege fields.

Full details: No-Sensitive-Data-In-Logs

Explanation

PASS. The pull request adds only a KUBECONFIG path and removes a credential mount. It adds no logging statements and does not log passwords, tokens, API keys, or kubeconfig contents. Existing logs for CI resource names and DNS zones are unchanged from the parent revision.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@bryan-cox: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-hypershift-main-azure-deprovision-azure-deprovision	N/A	periodic	Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[bryan-cox]

/pj-rehearse periodic-ci-openshift-hypershift-main-azure-deprovision-azure-deprovision

[openshift-merge-bot]

@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[bryan-cox]

/pj-rehearse periodic-ci-openshift-hypershift-main-azure-deprovision-azure-deprovision

[openshift-merge-bot]

@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[ironcladlou]

/lgtm

[bryan-cox]

/pj-rehearse ack

[openshift-merge-bot]

@bryan-cox: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

[csrwng]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, csrwng, ironcladlou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/step-registry/hypershift/azure/deprovision/OWNERS [bryan-cox,csrwng]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bryan-cox]

/pj-rehearse ack

[openshift-merge-bot]

@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.